Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass error messages from a transaction service to the safe-service-client #58

Closed
Graeme-Code opened this issue Aug 30, 2021 · 0 comments · Fixed by #64
Closed

Pass error messages from a transaction service to the safe-service-client #58

Graeme-Code opened this issue Aug 30, 2021 · 0 comments · Fixed by #64
Assignees
@germartinez

Comments

@Graeme-Code
Copy link

Graeme-Code commented Aug 30, 2021 •
edited
Loading

Background:
Got a ping from the Scaffold-eth team, they were frustrated at a blank error message received from the safe-service-client. Please see screenshot attatched:

When the team interacted directly with the transaction service, they found the error was that the addresses were not checksummed.

photo_2021-08-30 15 35 00
@germartinez germartinez self-assigned this Aug 30, 2021
@germartinez germartinez linked a pull request Sep 15, 2021 that will close this issue
(safe-service-client) Handle error messages and add e2e tests #64
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germartinez germartinez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(safe-service-client) Handle error messages and add e2e tests safe-global/safe-core-sdk
2 participants
@germartinez @Graeme-Code