Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in documentation of safe-core-sdk #97

Closed
cmdzro opened this issue Nov 5, 2021 · 1 comment · Fixed by #98
Closed

Error in documentation of safe-core-sdk #97

cmdzro opened this issue Nov 5, 2021 · 1 comment · Fixed by #98

Comments

@cmdzro
Copy link
Contributor

cmdzro commented Nov 5, 2021

Description

The documentation of the safe-core-sdk has an error in the API Reference / connect section:
https://github.com/gnosis/safe-core-sdk/tree/main/packages/safe-core-sdk#api-reference

The code sample for the contractNetworks property was probably copy-pasted from the create section. I assume it should use connect instead of create.

Expected result

Documentation should read like:

const safeSdk = await Safe.connect({ ethAdapter, safeAddress, contractNetworks })
@germartinez
Copy link
Member

True! Thank you for the catch! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants