Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze if we can easily develop an AsyncEthereumClient #1269

Open
Uxio0 opened this issue Aug 6, 2024 · 0 comments
Open

Analyze if we can easily develop an AsyncEthereumClient #1269

Uxio0 opened this issue Aug 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Uxio0
Copy link
Member

Uxio0 commented Aug 6, 2024

Context

  • Web3 supports async providers. It should be posible for us to do the same and allow people using async frameworks like FastAPI to use our EthereumClient
  • AsyncWeb3 must be used instead of Web3
  • Calls to self.http_session.post should be refactored to something similar to self.post_request or similar, so we don't expose what library are we using
  • Instead of requests, we aioHTTP must be used

Analyze if we can implement something similar with not much overhead. That might not be posible with our current implementation. If after the analysis we decide it takes more than one sprint to implement, we should meet and decide what to do

@Uxio0 Uxio0 added the enhancement New feature or request label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant