Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passkey signer error when using Bitwarden extension #500

Closed
richardhenry opened this issue Nov 20, 2024 · 2 comments
Closed

Passkey signer error when using Bitwarden extension #500

richardhenry opened this issue Nov 20, 2024 · 2 comments

Comments

@richardhenry
Copy link

richardhenry commented Nov 20, 2024

Description

One of our users is experiencing issues using the passkey signer with their Safe wallet in my dapp. I think the issue is that they are using the Bitwarden Chrome extension for passkeys/passwords, which doesn't seem to provide passkey data as an ArrayBuffer. This is probably non-standard behavior, but Bitwarden otherwise works fine for general passkey sign-in, so I suspect that maybe the WebAuthn code in the Safe library needs to be more robust.

Here is the error that they were seeing in their browser console:

Screenshot_2024-11-18_at_6 59 35_PM

Environment

  • @safe-global/protocol-kit@5.0.2
  • @safe-global/relay-kit@3.2.4
  • Chrome 130.0.6723.91 (Official Build) (arm64)
  • macOS Sonoma 14.6
  • Bitwarden browser extension 48.0

Steps to reproduce

  1. Use Google Chrome with the Bitwarden browser extension
  2. Call signSafeOperation with a passkey signer
@nlordell
Copy link
Collaborator

Thanks for the detailed issue report.

Any chance you can console.log the data passed into the DataView constructor? According to the WebAuthn standard it should be an ArrayBuffer and would be surprised if it were something else.

Also, this is done over the Safe{SDK} - so the issue should be moved to the appropriate repository https://github.com/safe-global/safe-core-sdk (this one is for the on-chain contracts).

@nlordell
Copy link
Collaborator

Moved here: safe-global/safe-core-sdk#1054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants