This repository has been archived by the owner on Jan 25, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a memory leak found in factories, where their container was never released from its parent container, add also specs to verify the fix
The following code will leak forever in the pre-fixed-version of intravenous:
// Heavy class
function heavyMemoryClass () {
this.array = new Array(1024*10);
}
heavyMemoryClass.$inject = [];
// Container configuration
var intravenous = require('intravenous');
var container = intravenous.create();
container.register('heavyMemoryClass', heavyMemoryClass, 'unique');
// Leak reproduction
var heavyMemoryClassFactory = container.get("heavyMemoryClassFactory");
setInterval(function () {
var myClass = heavyMemoryClassFactory.get();
heavyMemoryClassFactory.dispose(myClass);
}.bind(this), 10);