Make solve documentation better

[kcrisman]

To be precise, make sure the documentation at

sage: x.solve?

is available from

sage: solve?

There are a lot of keywords people are missing out on.

---

Apply to Sage library:

• attachment: trac_10444-solve.patch
• attachment: trac_10444_reviewer.patch

CC: @jasongrout @burcin @sagetrac-dsm @benjaminfjones

Component: documentation

Keywords: symbolic sd31

Author: Karl-Dieter Crisman

Reviewer: Benjamin Jones

Merged: sage-5.3.beta0

Issue created by migration from https://trac.sagemath.org/ticket/10444

[kcrisman]

comment:1

This patch at least begins to fix this issue. It just copies the most obvious examples. But I think it will help a lot.

Improvements welcome! Otherwise, please review.

[kcrisman]

Changed keywords from symbolic to symbolic sd31

[sagetrac-travis]

comment:3

When applying the patch to my version 4.7, I received the error:

applying /home/travis/.sage/temp/euler.math.mc/4600/tmp_0.patch
patching file sage/symbolic/expression.pyx
Hunk #1 succeeded at 7365 with fuzz 2 (offset -44 lines).
patching file sage/symbolic/relation.py
Hunk #1 FAILED at 478
Hunk #3 succeeded at 625 with fuzz 2 (offset 2 lines).
1 out of 3 hunks FAILED -- saving rejects to file sage/symbolic/relation.py.rej
abort: patch failed to apply

Also, what was left over had some odd spacing issues when checking x.solve?

[kcrisman]

comment:4

This patch is based on 4.7.1.alpha2.

However, I see in the patch preview that for some reason there is extra whitespace, so I'll have to take care of that sometime. For now, needs work for that reason.

[kcrisman]

Work Issues: fix whitespace issues

[kcrisman]

comment:5

Wow, I guess we let time forget this. Surprisingly, it still applies in the important place, and the stuff that doesn't apply is no longer needed.

Updated patch coming up.

[kcrisman]

Attachment: trac_10444-solve.patch.gz

[kcrisman]

Author: Karl-Dieter Crisman

[kcrisman]

comment:6

Okay, this really needs to get in. Hopefully a quite easy review.

[benjaminfjones]

very small reviewer patch

[benjaminfjones]

comment:7

Attachment: trac_10444_reviewer.patch.gz

Looks really good. Thanks for taking care of this. I spotted two very small typos, a reviewer patch is attached. I'll set to positive review once I've checked out the html documentation, but everything looks good from the terminal!

[benjaminfjones]

Reviewer: Benjamin Jones

[benjaminfjones]

comment:8

OK, lookin' good. Positive review.

[benjaminfjones]

Changed work issues from fix whitespace issues to none

[jdemeyer]

Merged: sage-5.3.beta0