Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PARI to version 2.5.0 #11130

Closed
jdemeyer opened this issue Apr 5, 2011 · 164 comments
Closed

Update PARI to version 2.5.0 #11130

jdemeyer opened this issue Apr 5, 2011 · 164 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Apr 5, 2011

We need to add bugfixes for

  1. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1147 (related to Implement Hilbert symbols over number fields #9334)
  2. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1153 (Occasional doctest failure in libs/fplll/fplll.pyx #10195)
  3. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1154 (PARI qfminim bug on 32-bit systems (Sage 4.7 and 4.6.2) #11604)
  4. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1184 (related to PARI real precision is broken in many ways #9937)
  5. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1185 (PARI bug discovered by a Sage doctest)
  6. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1186 (PARI performance regression discovered by a Sage doctest)
  7. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1187 (PARI bug discovered by a Sage doctest)
  8. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1188 (PARI bug discovered by a Sage doctest)
  9. http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1192 (Fractional ideals intersection gives wrong answers in some cases. #10767)

We will do this by updating to PARI version 2.5.0, which is equal to svn revision 13228.


See also:


Apply:

  1. spkg http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.0.p2.spkg (jdemeyer)
  2. spkg http://boxen.math.washington.edu/home/jdemeyer/spkg/lcalc-1.23.p9.spkg (from Make lcalc compatible with the new PARI #11321)
  3. attachment: 11130_sagelib.patch (jdemeyer, cremona)
  4. attachment: 11130-sagelib-simon-v2.patch (cremona, jdemeyer)
  5. attachment: 11130_reviewer32.patch (jdemeyer)
  6. attachment: 11130-4.7.2.alpha3.patch (jdemeyer)
  7. attachment: 11130-4.8.alpha1.patch (jdemeyer)
  8. extcode patch attachment: 11130-extcode-v2.patch (cremona, jdemeyer)

Depends on #11321

Dependencies: #11321 (install this '''after''' building PARI)

CC: @mstreng @dimpase @jpflori

Component: packages: standard

Keywords: pari spkg sd32

Author: Jeroen Demeyer, John Cremona

Reviewer: John Cremona, Jeroen Demeyer, William Stein

Merged: sage-4.8.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/11130

@jdemeyer jdemeyer added this to the sage-4.7 milestone Apr 5, 2011
@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer changed the title Add some patches to PARI Update PARI to a more recent SVN version Apr 5, 2011
@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer modified the milestones: sage-4.7, sage-4.7.1 Apr 11, 2011
@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Dependencies: #11230

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@JohnCremona
Copy link
Member

comment:17

I am currently testing this. To avoid duplication of effort, I'll fix things I find in the elliptic_curves directory only.

@JohnCremona
Copy link
Member

comment:18

After (1) Building a fresh 4.7.alpha5 from scratch, (2) installing the spkg lined here with "sage -f", (3) applying the patch here to the sage library and (4) running "sage -b", I find that the Sage build will not start up properly:

ImportError                               Traceback (most recent call last)
...

/home/jec/sage-4.7.alpha5.11130/local/lib/python2.6/site-packages/sage/misc/functional.py in <module>()
     36 
     37 
---> 38 from sage.rings.complex_double import CDF
     39 from sage.rings.real_double import RDF, RealDoubleElement
     40 

/home/jec/sage-4.7.alpha5.11130/local/bin/gen.pxd in init sage.rings.complex_double (sage/rings/complex_double.c:15178)()

ImportError: /home/jec/sage-4.7.alpha5.11130/local/lib/python2.6/site-packages/sage/libs/pari/gen.so: undefined symbol: defaultOut
Error importing ipy_profile_sage - perhaps you should run %upgrade?
WARNING: Loading of ipy_profile_sage failed.

so I cannot test anything.

Did I do something wrong?

@jdemeyer
Copy link
Author

comment:19

Replying to @JohnCremona:

Did I do something wrong?

This ticket depends on #11230.

@JohnCremona
Copy link
Member

comment:20

Replying to @jdemeyer:

Replying to @JohnCremona:

Did I do something wrong?

This ticket depends on #11230.

I see! I'll have some time to spend on this tomorrow (Monday) so I'll have another go.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Changed dependencies from #11230 to #11230, #11234

@jdemeyer jdemeyer self-assigned this Apr 25, 2011
@jdemeyer
Copy link
Author

comment:22

Replying to @JohnCremona:

I am currently testing this. To avoid duplication of effort, I'll fix things I find in the elliptic_curves directory only.

Sounds good, I will look at everything else.

@jdemeyer
Copy link
Author

Changed reviewer from John Cremona, Jeroen Demeyer to John Cremona, Jeroen Demeyer, William Stein

@jdemeyer
Copy link
Author

Changed dependencies from #11304, #11540, #11321 (install this '''after''' building PARI) to #11321 (install this '''after''' building PARI)

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer removed this from the sage-4.8 milestone Nov 1, 2011
@jdemeyer jdemeyer added this to the sage-4.8 milestone Nov 3, 2011
@jdemeyer jdemeyer removed the pending label Nov 3, 2011
@jdemeyer
Copy link
Author

jdemeyer commented Nov 3, 2011

Milestone sage-4.7.3 deleted

@jdemeyer jdemeyer removed this from the sage-4.8 milestone Nov 3, 2011
@jdemeyer
Copy link
Author

jdemeyer commented Nov 5, 2011

Fix 32-bit doctest for sage-4.8.alpha1

@jdemeyer
Copy link
Author

jdemeyer commented Nov 5, 2011

comment:141

Attachment: 11130-4.8.alpha1.patch.gz

Added an additional patch attachment: 11130-4.8.alpha1.patch. Not sure how this extra doctest failure happened, but in any case this trivial patch fixes it. It simply sets the 32-bit result equal to the 64-bit result. I hope nobody minds if I leave the positive_review (not to drag this ticket longer than necessary).

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer added this to the sage-4.8 milestone Nov 5, 2011
@JohnCremona
Copy link
Member

comment:142

Replying to @jdemeyer:

Added an additional patch attachment: 11130-4.8.alpha1.patch. Not sure how this extra doctest failure happened, but in any case this trivial patch fixes it. It simply sets the 32-bit result equal to the 64-bit result. I hope nobody minds if I leave the positive_review (not to drag this ticket longer than necessary).

Fine with me. The 32/64 bit differences in pari are such a nuisance, as I have told Karim more than once...

@jdemeyer
Copy link
Author

jdemeyer commented Nov 7, 2011

Merged: sage-4.8.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants
@kiwifb @williamstein @kcrisman @JohnCremona @jdemeyer @mstreng and others