Make testcc.sh exit with an exit code of 1 if preprocessing a file fails.

[sagetrac-drkirkby]

The script $SAGE_ROOT/spkg/bin/testcc.sh checks to see what C compiler the environment variable $CC is. But currently the script always exits with a 0, even if an error occurs.

This patch will correct that.

Note some forms of error will not be detected. If CC is defined as ls, then the code will try to list the C file, which will succeed without error. But the changes will allow one to check if a compiler is installed or not.

drkirkby@hawk:~$ export CC=cc
drkirkby@hawk:~$ sage-4.7.alpha3/local/bin/testcc.sh $CC
Sun_Studio
drkirkby@hawk:~$ export CC=gcc
drkirkby@hawk:~$ sage-4.7.alpha3/local/bin/testcc.sh $CC
GCC
drkirkby@hawk:~$ export CC=junk
drkirkby@hawk:~$ sage-4.7.alpha3/local/bin/testcc.sh $CC
Error - junk is not compiling a C file properly

Apply attachment: 11169_testcc.patch to the SAGE_ROOT repository.

CC: @jhpalmieri @mkoeppe @kliem

Component: scripts

Keywords: sd32

Author: David Kirkby

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/11169

[sagetrac-mariah]

comment:2

Where is test.cc used? It does not seem to be used by prereq-0.9 in sage-4.7.rc4.

[williamstein]

Changed keywords from none to sd32

[sagetrac-drkirkby]

comment:4

Replying to @sagetrac-mariah:

Where is test.cc used? It does not seem to be used by prereq-0.9 in sage-4.7.rc4.

Some of the .spkg's use it. Not many I must admit, but a few do, mainly in an attempt to support the Sun (now Oracle) compiler, but it might be used for AIX/HP-UX too.

It would be worth fixing this bug. It might be sensible to add support for 'clang' to this script later, although since that's supposed to be compatible with gcc, perhaps it's not needed.

[jdemeyer]

comment:5

Attachment: 11169_testcc.patch.gz

[jdemeyer]

comment:6

I'm not entirely sure this patch is a good idea. How universal is the command line option "-E" to run the preprocessor?

[fchapoton]

comment:11

is this ancient ticket now obsolete ?

[kliem]

comment:13

I agree that this is invalid.

Currently, there is no use case for this ticket. We only use local/bin/testcc.sh to check whether or not a compiler is GCC or Sun_Studio or HP_on_HP-UX. It is never used to check whether or not a compiler is suitable for anything.

[kliem]

Reviewer: Jonathan Kliem