Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not load sagenb.misc.misc on startup #11733

Closed
saraedum opened this issue Aug 24, 2011 · 17 comments
Closed

do not load sagenb.misc.misc on startup #11733

saraedum opened this issue Aug 24, 2011 · 17 comments

Comments

@saraedum
Copy link
Member

Not loading sagenb.misc.misc on normal sage startup speeds up sage startup:

$ dumbbench -- ./sage --startuptime
Ran 25 iterations (4 outliers).
Rounded run time per iteration: 9.80e-01 +/- 1.3e-02 (1.3%)

vs.

dumbbench -- ./sage --startuptime
Ran 21 iterations (1 outliers).
Rounded run time per iteration: 9.38e-01 +/- 1.5e-02 (1.6%)

Apply:

  1. attachment: trac_11733_sagenb_misc_misc_sage.patch to the Sage library.
  2. attachment: trac_11733_sagenb_misc_misc_sagenb.patch to the SageNB repository.

Depends on #11732

Component: notebook

Keywords: sd32

Reviewer: Julian Rueth

Issue created by migration from https://trac.sagemath.org/ticket/11733

@saraedum
Copy link
Member Author

Attachment: trac_11733_sagenb_misc_misc_sage.patch.gz

@saraedum
Copy link
Member Author

comment:1

Attachment: trac_11733_sagenb_misc_misc_sagenb.patch.gz

@saraedum
Copy link
Member Author

Changed author from Julian Rüth to Julian Rueth

@williamstein
Copy link
Contributor

Changed keywords from none to sd32

@robertwb
Copy link
Contributor

comment:4

Looks good. Wish it were a bigger spedup, but ever 1-2% counts (it's like compound interest ;-)

@nexttime

This comment has been minimized.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 8, 2011

comment:5

Does not apply to Sage 4.7.2.alpha2 / SageNB 0.8.21.

Also, please make use of the comment fields for attachments.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 8, 2011

Reviewer: Robert Bradshaw

@nexttime nexttime mannequin added s: needs work and removed s: positive review labels Sep 8, 2011
@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 8, 2011

comment:6

Replying to @nexttime:

Does not apply to Sage 4.7.2.alpha2 / SageNB 0.8.21.

Sorry, missed the dependency. Going to retry...

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 8, 2011

comment:7

Replying to @nexttime:

Replying to @nexttime:

Does not apply to Sage 4.7.2.alpha2 / SageNB 0.8.21.

Sorry, missed the dependency. Going to retry...

Still does not apply:

applying https://github.com/sagemath/sage-prod/files/10653531/trac_11733_sagenb_misc_misc_sagenb.patch.gz
patching file sagenb/misc/misc.py
Hunk #1 succeeded at 106 (offset 2 lines).
Hunk #2 FAILED at 163
Hunk #3 succeeded at 168 (offset -11 lines).
Hunk #4 FAILED at 334
Hunk #5 FAILED at 351
3 out of 5 hunks FAILED -- saving rejects to file sagenb/misc/misc.py.rej
patching file sagenb/notebook/interact.py
patching file sagenb/notebook/notebook.py
Hunk #1 succeeded at 30 with fuzz 2 (offset 0 lines).
Hunk #2 succeeded at 619 (offset 5 lines).
Hunk #3 succeeded at 1592 with fuzz 1 (offset -2 lines).
patching file sagenb/notebook/run_notebook.py
abort: patch failed to apply

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 8, 2011

Work Issues: Rebase on Sage 4.7.2.alpha2.

@saraedum
Copy link
Member Author

comment:9

the sagenb.misc.misc import is faster in the latest alpha and it's harder to get rid of it now, so I guess it's not worth it anymore.

@saraedum saraedum removed this from the sage-4.7.2 milestone Sep 21, 2011
@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 21, 2011

comment:10

Replying to @saraedum:

the sagenb.misc.misc import is faster in the latest alpha and it's harder to get rid of it now, so I guess it's not worth it anymore.

Are you referring to alpha2 or the alpha3 prerelease?

Anyway, I can close this ticket if you give it "positive review" in the sense that it is invalid / fixed / no longer worth doing.

@nexttime nexttime mannequin added s: needs info and removed s: needs work labels Sep 29, 2011
@saraedum
Copy link
Member Author

comment:12

no longer worth doing.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 29, 2011

Changed reviewer from Robert Bradshaw to Julian Rueth

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 29, 2011

Changed work issues from Rebase on Sage 4.7.2.alpha2. to none

@nexttime
Copy link
Mannequin

nexttime mannequin commented Sep 29, 2011

Changed author from Julian Rueth to none

@nexttime nexttime mannequin removed the s: positive review label Sep 29, 2011
@nexttime nexttime mannequin closed this as completed Sep 29, 2011
@nexttime nexttime mannequin added r: worksforme and removed p: minor / 4 labels Sep 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants