-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MPFI to 1.5.1 #12171
Comments
comment:2
There is spkg at http://sage.math.washington.edu/home/mhansen/mpfi-1.5.0.spkg |
comment:3
Have you checked the following doctests:
and
I did those test about one year ago cschwan/sage-on-gentoo#30 so some things have probably changed a little bit but I expect you'll have to patch sage. |
comment:4
by the way, MPFI 1.5.0 fixes a limitation to 1000 characters in
which failed previously. Maybe add a test for that? Paul |
comment:5
two doctests are failing:
The issues are Paul |
comment:6
there is one important change in MPFI 1.5.0 which might cause the failures:
More annoying is the following, which I believe is a bug in MPFI 1.5.0:
(I would expect Paul |
Changed keywords from none to sd35 |
comment:8
the detailed failures (on a 32-bit computer) are:
and:
Paul |
comment:9
the first issue with gamma seems to be due to that bug in Sage:
(works for precision 53 or less). Paul |
comment:10
I got a message from the developers of the Sollya package who say that they had similar Paul |
comment:11
the problem from comment [comment:9] seems to only apply on 32-bit machines. I'll first try to
The MPFI developers claim that in MPFI 1.5 the sign of 0 is irrelevant, but this is still a Paul |
Attachment: trac_12171a.patch.gz |
comment:12
the attached
I see in
Indeed
Should I also rewrite the 2 failing tests like this? What is the reason for the failures? Paul |
comment:13
Robert, Mike, are you there? Paul |
comment:14
Jeroen, since I got no answer to my question I ask you: do you have an idea how to proceed? Paul |
comment:15
Hi Paul, sorry for the delay; I've been busy with traveling back to the states / the holidays. I'll look into why these are failing today. I started while I was in Warwick, but didn't make much progress. |
comment:17
Replying to @zimmermann6:
This is quite strange I cannot think of a reason this would fail unless the "==" operator is doing something slightly wrong or something unexpected. |
comment:18
ok I understand why the following "fails":
In the
Paul |
this patch should be applied after trac_12171a.patch |
comment:19
Attachment: trac_12171b.patch.gz the second patch attached fixes the remaining failing tests. Ready for review. Paul |
This comment has been minimized.
This comment has been minimized.
comment:63
Francois, I just built Sage 5.0.beta1 on another 64 bit linux (Core2 under Ubuntu 10.10) and got:
Paul |
comment:65
Francois, no, I didn't use #11666. Can anybody reproduce the problem I have (cf #12353)? Paul |
comment:66
Everything I said was without #11666. |
comment:67
Replying to @zimmermann6:
I can reproduce it on OS X 10.5.8 (32bit) and linux on ppc64, but not on linux x86_64. You are probably right that's an orthogonal problem if it can happen as well in the current version of sage. |
comment:68
since this ticket got a positive review at comment [comment:49], and the doctest Paul |
comment:69
If nothing on this ticket changed, I guess we're back to positive review with a dependency on #12353. |
comment:71
Jeroen, now that #12353 has been fixed, you can merge this one too. Paul |
comment:72
Replying to @zimmermann6:
Don't worry, it's on my radar and should be merged in sage-5.0.beta5 if no further problems arise. |
comment:73
In
|
comment:74
An updated package is available at the same address. I also added a mecurial tag for mpfi-1.5.1. |
Changed keywords from sd35 to sd35 sd36 |
comment:75
Looks good! |
Merged: sage-5.0.beta6 |
This is needed for #11666.
Use http://perso.telecom-paristech.fr/~flori/sage/mpfi-1.5.1.spkg
Apply first attachment: trac_12171a.patch, then attachment: trac_12171b.patch
Depends on #12131
Depends on #12353
CC: @sagetrac-cwitty @robertwb @jdemeyer @jpflori
Component: packages: standard
Keywords: sd35 sd36
Author: Mike Hansen, Paul Zimmermann, Jean-Pierre Flori
Reviewer: François Bissey
Merged: sage-5.0.beta6
Issue created by migration from https://trac.sagemath.org/ticket/12171
The text was updated successfully, but these errors were encountered: