pass algorithm argument to custom numeric evaluation methods #12289

burcin · 2012-01-10T06:38:35Z

Custom numeric evaluation functions defined in the _evalf_() method of symbolic functions accept only the parent of the result as an argument. We should expand this to allow passing an algorithm parameter as well.

Merge together with dependencies (i.e. there are circular dependencies).

Depends on #13933
Depends on #4102
Depends on #15198

CC: @benjaminfjones @sagetrac-dsm @kcrisman @kini @eviatarbach @vbraun

Component: symbolics

Keywords: pynac sd35.5 sd40.5 sd48

Author: Burcin Erocal, Benjamin Jones

Branch: ef6d2de

Reviewer: Karl-Dieter Crisman, Douglas MacNeil, Benjamin Jones, Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/12289

The text was updated successfully, but these errors were encountered:

burcin · 2012-01-10T07:41:06Z

Attachment: trac_12289-evalf_dictionary.patch.gz

burcin · 2012-01-10T08:00:12Z

Attachment: trac_12289-add_algorithm_arg.patch.gz

Attachment: trac_12289-example.patch.gz

burcin · 2012-01-10T08:05:24Z

comment:1

The evalf_dict branch of Pynac available here, with the attached patches applied to the Sage library, allows this:

sage: cot(1/2).n(algorithm='foo')
11.0000000000000
sage: cot(1/2).n()
1.83048772171245

The docstrings for _convert() etc. methods of symbolic expressions need to be updated to reflect these changes.

benjaminfjones · 2012-01-10T15:46:42Z

comment:2

I'm doing some testing of these patches along with rebasing #1173. Thanks Burcin!

benjaminfjones · 2012-01-10T15:46:42Z

Changed keywords from pynac to pynac sd35.5

benjaminfjones · 2012-05-25T02:27:32Z

Changed keywords from pynac sd35.5 to pynac sd35.5 sd40.5

benjaminfjones · 2012-05-26T00:26:32Z

comment:4

I'm trying to rebase the patch attachment: trac_12289-evalf_dictionary.patch to sage-5.0, but I'm running into a problem with the type of py_funcs.py_float. In the patch py_float has type object (*)(object, object) but in sage-5.0, it has type object (*)(object, PyObject *) I guess because of a pynac change in the meantime.

To be more specific, with this type def for py_float:

cdef public object py_float(object n, object kwds) except +:

I rebuild sage and get:


Error compiling Cython file:
------------------------------------------------------------
...
    py_funcs.py_is_prime = &py_is_prime

    py_funcs.py_integer_from_long = &py_integer_from_long
    py_funcs.py_integer_from_python_obj = &py_integer_from_python_obj
    
    py_funcs.py_float = &py_float
                       ^
------------------------------------------------------------

sage/symbolic/pynac.pyx:2040:24: Cannot assign type 'object (*)(object, object)' to 'object (*)(object, PyObject *)'

Any suggestions (burcin?)

benjaminfjones · 2012-05-28T02:22:16Z

Attachment: trac_12289-evalf_dictionary_rebase.patch.gz

rebase to sage-5.0 + pynac-0.2.4 spkg

benjaminfjones · 2012-05-28T02:22:45Z

Attachment: trac_12289_py_float_fix.patch.gz

fix py_float delcaration

benjaminfjones · 2012-05-28T02:33:32Z

comment:7

I've been working on this ticket today at sd40.5. I've got burcin's changes working in sage-5.0 with a caveat. Here's how to get the example in comment:1 working in sage-5.0:

install the __patched__ pynac-0.2.4.p1 spkg at http://sage.math.washington.edu/home/bjones/pynac-0.2.4.p1.spkg. this spkg is the pynac-0.2.4 spkg from update to Pynac 0.2.4 #12950 which has been patched to include the changes from burcin's pynac-wip branch of pynac mentioned above.
apply all patches at update to Pynac 0.2.4 #12950, here is a shell script to help that (run from $SAGE_ROOT/devel/sage): http://sage.math.washington.edu/home/bjones/trac_12950_apply.sh
apply the patches to $SAGE_ROOT/devel/sage
- attachment: trac_12289-evalf_dictionary_rebase.patch
- attachment: trac_12289-add_algorithm_arg.patch
- attachment: trac_12289-example.patch
- attachment: trac_12289_py_float_fix.patch (fixes the problem I had in comment:4)
sage -b

kcrisman · 2012-05-28T04:28:06Z

comment:8

Patchbot, though, should only apply trac_12289-evalf_dictionary_rebase.patch, trac_12289-add_algorithm_arg.patch, and trac_12289_py_float_fix.patch

sagetrac-dsm · 2012-05-28T18:10:51Z

comment:9

So that we don't forget to fix it later:


sage: erf(1).n(algorithm='foo')
0.842700792949715
sage: erf(0)
0
sage: parent(erf(0))
Integer Ring
sage: erf(0).n(algorithm='foo')
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

/Users/mcneil/sagedev/sage-5.1.beta0b/sage-5.1.beta0/devel/sage-hack2/sage/<ipython console> in <module>()

/Users/mcneil/sagedev/sage-5.1.beta0b/sage-5.1.beta0/local/lib/python2.7/site-packages/sage/structure/element.so in sage.structure.element.Element.numerical_approx (sage/structure/element.c:4988)()

TypeError: numerical_approx() got an unexpected keyword argument 'algorithm'

kcrisman · 2013-04-25T02:23:41Z

comment:10

install the __patched__ pynac-0.2.4.p1 spkg at http://sage.math.washington.edu/home/bjones/pynac-0.2.4.p1.spkg. this spkg is the pynac-0.2.4 spkg from update to Pynac 0.2.4 #12950 which has been patched to include the changes from burcin's pynac-wip branch of pynac mentioned above.

Is this stuff in the current Pynac 0.2.6?

apply all patches at update to Pynac 0.2.4 #12950, here is a shell script to help that (run from $SAGE_ROOT/devel/sage): http://sage.math.washington.edu/home/bjones/trac_12950_apply.sh

Can now be skipped, presumably.

apply the patches to $SAGE_ROOT/devel/sage

attachment: trac_12289-evalf_dictionary_rebase.patch

attachment: trac_12289-add_algorithm_arg.patch

attachment: trac_12289-example.patch

attachment: trac_12289_py_float_fix.patch (fixes the problem I had in comment:4)

sage -b

kcrisman · 2013-06-19T00:55:45Z

comment:12

Some of these patches have bitrotted slightly. Updates coming up.

kcrisman · 2013-06-19T01:03:06Z

comment:13

Regarding Doug's comment on

erf(0).n(algorithm='foo')

Is this something we want to fix here? I'm not sure whether this is behavior that is supported with this patch, though perhaps it should be. I think that so far this is only putting in infrastructure, right? I don't see any doctests here, for instance.

kcrisman · 2013-06-19T01:04:59Z

Attachment: trac_12289-py_float-fix-rebase.patch.gz

kcrisman · 2013-06-19T01:06:58Z

comment:14

Attachment: trac_12289-add_algorithm-rebase.patch.gz

kcrisman · 2013-06-19T01:17:12Z

comment:15

Patchbot, apply trac_12289-evalf_dictionary_rebase.patch , trac_12289-add_algorithm-rebase.patch , and trac_12289-py_float-fix-rebase.patch

kcrisman · 2013-06-19T01:50:36Z

comment:16

I think that we definitely need at least one example of how to do this if we aren't going to have any other documentation here.

kcrisman · 2013-06-19T02:03:40Z

Work Issues: doctests, documentation

kcrisman · 2013-06-19T02:03:40Z

comment:17

We need to fix this.

----------------------------------------------------------------------
sage -t sage/symbolic/expression.pyx  # 3 doctests failed
sage -t sage/functions/other.py  # Killed due to segmentation fault
sage -t sage/functions/exp_integral.py  # 25 doctests failed
sage -t sage/functions/log.py  # 4 doctests failed
sage -t sage/symbolic/pynac.pyx  # 2 doctests failed
sage -t sage/symbolic/function.pyx  # 1 doctest failed
----------------------------------------------------------------------

But it does work!

kcrisman · 2013-06-19T02:03:40Z

Reviewer: Karl-Dieter Crisman, Doug S. MacNeil, Benjamin Jones

jpflori · 2014-02-20T11:30:49Z

Commit: 5d1fd33

jpflori · 2014-02-20T11:30:49Z

Branch: u/jpflori/ticket/12289

sagetrac-git · 2014-02-20T11:43:13Z

Changed commit from 5d1fd33 to b658858

sagetrac-git · 2014-02-20T11:43:13Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b658858`	`Proper fix for the rebasing issue.`

sagetrac-git · 2014-02-20T11:54:04Z

Changed commit from b658858 to da159a0

sagetrac-git · 2014-02-20T11:54:04Z

Branch pushed to git repo; I updated commit sha1. New commits:

`da159a0`	`Add missing fix for algorithm keyword for custom numerical evaluation.`

jpflori · 2014-02-20T13:18:37Z

Changed work issues from doctests, documentation to blankline

jpflori · 2014-02-20T13:18:37Z

comment:36

I just rebased the old patches and fixed an additional missing new keyword.
I'm happy with the changes.
There is still the blankline issue of comment:29.

jpflori · 2014-02-20T13:18:37Z

Changed reviewer from Karl-Dieter Crisman, Doug S. MacNeil, Benjamin Jones to Karl-Dieter Crisman, Doug S. MacNeil, Benjamin Jones, Jean-Pierre Flori

sagetrac-git · 2014-02-20T14:12:03Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ef6d2de`	`Fix documentation for numerical_approximation.`

sagetrac-git · 2014-02-20T14:12:03Z

Changed commit from da159a0 to ef6d2de

jpflori · 2014-02-20T14:35:29Z

comment:38

In fact the doctest was expected to change... so needs review for the two basic changes I made.
What was done before was already reviewed and I'm happy in case it was not.

New commits:

`ef6d2de`	`Fix documentation for numerical_approximation.`

kcrisman · 2014-02-28T15:45:37Z

comment:40

I can't do actual testing now (or any time soon, I've really fallen off the development radar screen) but these minor changes in the last two commits are completely fine as long as the doc change fixes the problem. Hopefully we'll actually start implementing some of these algorithms now...

jpflori · 2014-02-28T15:46:57Z

comment:41

Testing will be done automatically by the patchbots, so I'll take your comment as positive review.

vbraun · 2014-03-04T16:58:44Z

Changed branch from u/jpflori/ticket/12289 to ef6d2de

kcrisman · 2014-11-14T21:16:15Z

Changed commit from ef6d2de to none

kcrisman · 2014-11-14T21:16:15Z

Changed reviewer from Karl-Dieter Crisman, Doug S. MacNeil, Benjamin Jones, Jean-Pierre Flori to Karl-Dieter Crisman, Douglas MacNeil, Benjamin Jones, Jean-Pierre Flori

kcrisman · 2014-11-14T21:16:15Z

Changed work issues from blankline to none

jdemeyer · 2014-12-19T21:05:25Z

comment:44

Is there any particular reason that this was done for _evalf_ and not also plain _eval_?

jdemeyer · 2014-12-19T21:13:33Z

comment:45

Similarly: shouldn't __call__ support an algorithm argument such that one could do

sage: f(0.12345, algorithm="foobar")

burcin added this to the sage-5.11 milestone Jan 10, 2012

burcin added c: symbolics labels Jan 10, 2012

burcin self-assigned this Jan 10, 2012

This comment has been minimized.

Sign in to view

jpflori added s: positive review and removed s: needs review labels Feb 28, 2014

vbraun removed the s: positive review label Mar 4, 2014

vbraun closed this as completed in 7a440b6 Mar 4, 2014

This comment has been minimized.

Sign in to view

sagetrac-olazo mannequin mentioned this issue May 27, 2015

Make Airy functions symbolic #12455

Closed

benjaminfjones mentioned this issue Dec 29, 2022

allow different algorithms for evaluating erf #13050

Open

kcrisman mentioned this issue Mar 4, 2014

Fix numerical_approx with algorithm keyword #14778

Closed

This was referenced Mar 4, 2014

Upgrade Pynac to 0.3.1 #15198

Closed

_evalf_ handling of backends #15200

Open

pass algorithm argument to custom numeric evaluation methods #12289

pass algorithm argument to custom numeric evaluation methods #12289

Comments

burcin commented Jan 10, 2012

burcin commented Jan 10, 2012

burcin commented Jan 10, 2012

burcin commented Jan 10, 2012

benjaminfjones commented Jan 10, 2012

benjaminfjones commented Jan 10, 2012

benjaminfjones commented May 25, 2012

benjaminfjones commented May 26, 2012

benjaminfjones commented May 28, 2012

benjaminfjones commented May 28, 2012

benjaminfjones commented May 28, 2012

kcrisman commented May 28, 2012

This comment has been minimized.

sagetrac-dsm mannequin commented May 28, 2012

kcrisman commented Apr 25, 2013

kcrisman commented Jun 19, 2013

kcrisman commented Jun 19, 2013

kcrisman commented Jun 19, 2013

kcrisman commented Jun 19, 2013

This comment has been minimized.

kcrisman commented Jun 19, 2013

This comment has been minimized.

kcrisman commented Jun 19, 2013

kcrisman commented Jun 19, 2013

kcrisman commented Jun 19, 2013

kcrisman commented Jun 19, 2013

jpflori commented Feb 20, 2014

jpflori commented Feb 20, 2014

sagetrac-git mannequin commented Feb 20, 2014

sagetrac-git mannequin commented Feb 20, 2014

sagetrac-git mannequin commented Feb 20, 2014

sagetrac-git mannequin commented Feb 20, 2014

jpflori commented Feb 20, 2014

jpflori commented Feb 20, 2014

jpflori commented Feb 20, 2014

sagetrac-git mannequin commented Feb 20, 2014

sagetrac-git mannequin commented Feb 20, 2014

jpflori commented Feb 20, 2014

kcrisman commented Feb 28, 2014

jpflori commented Feb 28, 2014

vbraun commented Mar 4, 2014

kcrisman commented Nov 14, 2014

kcrisman commented Nov 14, 2014

kcrisman commented Nov 14, 2014

This comment has been minimized.

jdemeyer commented Dec 19, 2014

jdemeyer commented Dec 19, 2014