-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dir(RIF) contains duplicates #13043
Comments
Changed keywords from sd40.5 to beginner sd40.5 |
comment:2
I don't seem to see the patch. |
comment:3
Attachment: trac_13043.patch.gz hehe, you've been too fast. I needed the ticket number first to mention it in the TESTS section. I'm running the full doctests now, after that I'll set it to needs review; but feel free to have a look already. |
Author: Julian Rueth |
comment:5
The problem with using the previous approach was that various inputs to |
comment:6
Replying to @roed314:
Is this just for performance reasons? |
comment:7
Yeah. But I didn't mark it as needs work since I wanted another opinion. And since I haven't compared the performance of the two options. |
comment:8
Is dir() actually used in a performance critical spot? I had just assumed it was basically for introspection. |
comment:9
It probably is just for introspection. If someone else wants to give Julian's solution a positive review I'll be totally happy. :-) |
Reviewer: Mike Hansen |
comment:10
I looked at it and think that it's fine. |
Merged: sage-5.1.beta2 |
Currently, dir(RIF), and probably a few others, contains duplicates:
The attached patch fixes this problem.
Component: categories
Keywords: beginner sd40.5
Author: Julian Rueth
Reviewer: Mike Hansen
Merged: sage-5.1.beta2
Issue created by migration from https://trac.sagemath.org/ticket/13043
The text was updated successfully, but these errors were encountered: