Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import sage.libs.lcalc.lcalc_Lfunction #13351

Closed
jpflori opened this issue Aug 8, 2012 · 18 comments
Closed

Cannot import sage.libs.lcalc.lcalc_Lfunction #13351

jpflori opened this issue Aug 8, 2012 · 18 comments

Comments

@jpflori
Copy link

jpflori commented Aug 8, 2012

Cygchecking the package shows that it looks for an inexistent libLfunction.so.
Indeed, this file is moved to libLfunction.dll on Cygwin to let Sage build.
But at runtime, it is the original .so file which is looked for (surely some DT_SONAME equivalent).
Letting libLfunction.so in place and symlinking it from libLfunction.dll seems more functional.

A better solution would to tell lcalc to build directly a .dll file on Cygwin (and .dylib on Mac OS X, etc.).
Updated spkg doing so at
http://perso.telecom-paristech.fr/~flori/sage/lcalc-1.23.p11.spkg
or
http://www.infres.enst.fr/~flori/sage/lcalc-1.23.p11.spkg

Apply attachment: trac_13351.patch

CC: @kcrisman @dimpase

Component: porting: Cygwin

Keywords: cygwin spkg lcalc

Author: Jean-Pierre Flori

Reviewer: Dmitrii Pasechnik

Merged: sage-5.9.beta0

Issue created by migration from https://trac.sagemath.org/ticket/13351

@jpflori jpflori added this to the sage-5.8 milestone Aug 8, 2012
@jpflori
Copy link
Author

jpflori commented Aug 8, 2012

comment:1

Update lcalc spkg, modifying lot of the Makefile (that we already modify and which is not that nice) available at
http://perso.telecom-paristech.fr/~flori/sage/lcalc-1.23.p11.spkg

This will also need a Sage library patch.

@jpflori
Copy link
Author

jpflori commented Aug 8, 2012

Attachment: trac_13351.patch.gz

Attachment: lcalc.diff.gz

Spkg diff, for review only.

@jpflori

This comment has been minimized.

@jpflori
Copy link
Author

jpflori commented Aug 8, 2012

Author: Jean-Pierre Flori

@jpflori

This comment has been minimized.

@kcrisman
Copy link
Member

comment:4

Does this fix #9165?

@jpflori
Copy link
Author

jpflori commented Jan 15, 2013

comment:5

No idea :) give it a try.

@jpflori
Copy link
Author

jpflori commented Feb 27, 2013

comment:7

I think its the last ticket needed to correctly build Sage and get a working version except for a few doctests.
It would be great to have it for 5.8, nobody wants to have a look?

@kcrisman
Copy link
Member

comment:8

I'm sorry, Jean-Pierre - I agree, but I simply have had no time at work to deal with my XP box (esp. since the 32-bit issue apparently is preventing proper rebasing, as discussed somewhere). I hope to try again over spring break in a couple weeks.

@dimpase
Copy link
Member

dimpase commented Feb 28, 2013

comment:9

Replying to @jpflori:

I think its the last ticket needed to correctly build Sage and get a working version except for a few doctests.
It would be great to have it for 5.8, nobody wants to have a look?

I'm away at a conference, and don't have access to a WIndows machine, until Sunday. And then I'll have jetlag :-)
So it has to wait for few days, sorry.

@jpflori
Copy link
Author

jpflori commented Feb 28, 2013

comment:10

No hurry, it's just that its been rottijg around for some monthes, so Id like to get it ressurected :)

@dimpase
Copy link
Member

dimpase commented Mar 4, 2013

comment:11

I still get import problems:

$ ./sage -t -long devel/sage/sage/libs/lcalc/
sage -t -long "devel/sage/sage/libs/lcalc/lcalc_Lfunction.pyx"
**********************************************************************
File "/usr/local/src/sage/sage-5.7.beta2/devel/sage/sage/libs/lcalc/lcalc_Lfunction.pyx", l 55:
    sage: from sage.libs.lcalc.lcalc_Lfunction import *
Exception raised:
    Traceback (most recent call last):
      File "/usr/local/src/sage/sage-5.7.beta2/local/bin/ncadoctest.py", line 1231, in run__test
        self.run_one_example(test, example, filename, compileflags)
      File "/usr/local/src/sage/sage-5.7.beta2/local/bin/sagedoctest.py", line 38, in run_oexample
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/usr/local/src/sage/sage-5.7.beta2/local/bin/ncadoctest.py", line 1172, in run__example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_1[2]>", line 1, in <module>
        from sage.libs.lcalc.lcalc_Lfunction import *###line 55:
    sage: from sage.libs.lcalc.lcalc_Lfunction import *
    ImportError: No such file or directory

etc etc etc

indeed:

sage: import sage.libs.lcalc.lcalc_Lfunction
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-a629fe51f139> in <module>()
----> 1 import sage.libs.lcalc.lcalc_Lfunction

ImportError: No such file or directory
sage:

note that

sage: import sage.libs.lcalc

works.

@jpflori
Copy link
Author

jpflori commented Mar 4, 2013

comment:13

Replying to @dimpase:

I still get import problems:

$ ./sage -t -long devel/sage/sage/libs/lcalc/
sage -t -long "devel/sage/sage/libs/lcalc/lcalc_Lfunction.pyx"
**********************************************************************
File "/usr/local/src/sage/sage-5.7.beta2/devel/sage/sage/libs/lcalc/lcalc_Lfunction.pyx", l 55:
    sage: from sage.libs.lcalc.lcalc_Lfunction import *
Exception raised:
    Traceback (most recent call last):
      File "/usr/local/src/sage/sage-5.7.beta2/local/bin/ncadoctest.py", line 1231, in run__test
        self.run_one_example(test, example, filename, compileflags)
      File "/usr/local/src/sage/sage-5.7.beta2/local/bin/sagedoctest.py", line 38, in run_oexample
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/usr/local/src/sage/sage-5.7.beta2/local/bin/ncadoctest.py", line 1172, in run__example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_1[2]>", line 1, in <module>
        from sage.libs.lcalc.lcalc_Lfunction import *###line 55:
    sage: from sage.libs.lcalc.lcalc_Lfunction import *
    ImportError: No such file or directory

etc etc etc

indeed:

sage: import sage.libs.lcalc.lcalc_Lfunction
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-a629fe51f139> in <module>()
----> 1 import sage.libs.lcalc.lcalc_Lfunction

ImportError: No such file or directory
sage:

Did you install the patch to the Sage library and rebuilt it as well?

note that

sage: import sage.libs.lcalc

works.

That's expected, this file is not touched and does not depend on the spkg.

@dimpase
Copy link
Member

dimpase commented Mar 4, 2013

comment:14

yes, I certainly applied trac_13351.patch and ran sage -b. (on 5.7.beta2, but I guess it should not matter).

@dimpase
Copy link
Member

dimpase commented Mar 4, 2013

comment:15

Replying to @dimpase:

yes, I certainly applied trac_13351.patch and ran sage -b. (on 5.7.beta2, but I guess it should not matter).

what happened is that the Python extension didn't get rebuilt, as the patch didn't touch the corresponding pyx file! So I touched this file, and now everything works. Positive review.

@jdemeyer
Copy link

jdemeyer commented Mar 5, 2013

Reviewer: Dmitrii Pasechnik

@jdemeyer jdemeyer modified the milestones: sage-5.8, sage-5.9 Mar 5, 2013
@kcrisman
Copy link
Member

kcrisman commented Mar 8, 2013

comment:17

It works on XP too!

@jdemeyer
Copy link

Merged: sage-5.9.beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants