Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up arguments to all plotting functions #13828

Open
ppurka opened this issue Dec 13, 2012 · 12 comments
Open

Clean up arguments to all plotting functions #13828

ppurka opened this issue Dec 13, 2012 · 12 comments

Comments

@ppurka
Copy link
Member

ppurka commented Dec 13, 2012

Different plot commands have different arguments or keywords for achieving the same final effect. This is very confusing.

This ticket aims to go through the plot functions one by one and fix the arguments so that the Sage interface remains consistent and uniform across all the plot commands irrespective of the underlying plotting method used (currently matplotlib).

It is conceivable that the changes could be extensive (there are many plot functions) - then the changes can be broken up into other tickets and added to the "Dependencies" of this one.

Depends on #8570
Depends on #13830
Depends on #13834
Depends on #13576
Depends on #15002
Depends on #10032

CC: @kcrisman @novoselt

Component: graphics

Issue created by migration from https://trac.sagemath.org/ticket/13828

@ppurka

This comment has been minimized.

@sagetrac-afleckenstein
Copy link
Mannequin

sagetrac-afleckenstein mannequin commented Dec 19, 2012

comment:3

Is there an example of this? Also, how should we determine what keywords should be used as the standard ones?

@ppurka
Copy link
Member Author

ppurka commented Dec 19, 2012

comment:4

Unfortunately, there are quite a few such examples. One such I was fixing in #12798 (I intend to break out the color changes to a separate ticket and make that a dependency of this one), there are discussions in #13830, #8570, #13834, and all of this when we haven't even started to look at all the commands in detail.

(I am quite preoccupied for a couple of weeks, so it will take a while before I can come back to all these tickets, and start looking at them in detail.)

@ppurka
Copy link
Member Author

ppurka commented Jan 30, 2013

comment:6

Another one mentioned in sage-support:

> When desperate, I add invisible points and use show(). (Unfortunately 
> invisible points depend on your plot type since alpha=0 is for 2d and 
> opacity=0 is for 3d...HINT to developers to change this...)

@ppurka
Copy link
Member Author

ppurka commented Mar 23, 2013

comment:7

From here:

Somewhere in this set of related tickets we should also unify the usage of
figsize between graphics objects and graphics arrays. Maybe graphics
arrays need to be a separate file eventually..

@ppurka
Copy link
Member Author

ppurka commented Apr 17, 2013

Dependencies: #8570, #13830, #13834

@ppurka
Copy link
Member Author

ppurka commented Apr 17, 2013

comment:8

Let's add some dependencies.

@kcrisman
Copy link
Member

comment:9

How about #13576 too? Not that any of them have patches.

@kcrisman
Copy link
Member

Changed dependencies from #8570, #13830, #13834 to #8570, #13830, #13834, #13576

@ppurka
Copy link
Member Author

ppurka commented Aug 6, 2013

Changed dependencies from #8570, #13830, #13834, #13576 to #8570, #13830, #13834, #13576, #15002

@ppurka
Copy link
Member Author

ppurka commented Aug 6, 2013

comment:10

Adding #15002 to the list. It arises out of the examples provided by @kcrisman in #13576.

@ppurka
Copy link
Member Author

ppurka commented Aug 11, 2013

Changed dependencies from #8570, #13830, #13834, #13576, #15002 to #8570, #13830, #13834, #13576, #15002, #10032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants