Gap 4.6.3 upgrade

[vbraun]

And now MPIR defines __GNU_MP_RELEASE so the __GMP_MP_RELEASE hack is not needed anymore here or in gap spkg.

• GAP spkg: http://sage.math.washington.edu/home/vbraun/spkg/gap-4.6.3.p0.spkg
• LibGAP spkg: http://sage.math.washington.edu/home/vbraun/spkg/libgap-4.6.3.p0.spkg
• http://sage.math.washington.edu/home/vbraun/spkg/gap_packages-4.6.3.spkg
• http://sage.math.washington.edu/home/vbraun/spkg/database_gap-4.6.3.spkg
• Apply attachment: trac_14039_doctest_fixes.patch to the Sage library

Depends on #14014

Component: packages: standard

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/14039

[jdemeyer]

comment:2

Would this require also an upgrade of gap_packages?

[jdemeyer]

Author: Jeroen Demeyer

[jdemeyer]

comment:5

Volker, any idea what to do about this:

sage -t  "devel/sage/sage/groups/libgap_wrapper.pyx"
An error occurred, but libGAP has no handler set.
Error message:
An error occurred, but libGAP has no handler set.
Error message:
**********************************************************************
File "/release/merger/sage-5.8.beta4/devel/sage/sage/groups/libgap_wrapper.pyx", line 12:
    sage: from sage.groups.libgap_wrapper import ElementLibGAP, ParentLibGAP
Exception raised:
    Traceback (most recent call last):
      File "/release/merger/sage-5.8.beta4/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/release/merger/sage-5.8.beta4/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/release/merger/sage-5.8.beta4/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_0[2]>", line 1, in <module>
        from sage.groups.libgap_wrapper import ElementLibGAP, ParentLibGAP###line 12:
    sage: from sage.groups.libgap_wrapper import ElementLibGAP, ParentLibGAP
      File "libgap_wrapper.pyx", line 62, in init sage.groups.libgap_wrapper (sage/groups/libgap_wrapper.c:5712)
      File "libgap.pyx", line 574, in init sage.libs.gap.libgap (sage/libs/gap/libgap.c:4203)
      File "libgap.pyx", line 395, in sage.libs.gap.libgap.Gap.__init__ (sage/libs/gap/libgap.c:2747)
      File "util.pyx", line 215, in sage.libs.gap.util.initialize (sage/libs/gap/util.c:3538)
    RuntimeError: libGAP initialization failed


    You are running a GAP kernel which does not fit with the library.
    Probably you forgot to apply the kernel part or the library part
    of a bugfix?

    If you are using Windows, make sure you installed the file
    wbin4r6n2.zoo (or .zip),
    Macintosh users make sure the file
    bin4r6n2-PPC.sit (or -68k.sit) is installed,
    Unix users please recompile.

    Error before error-handling is initialized: Update to correct kernel version!


    #W Static module lib/oper1.g has CRC mismatch, ignoring
    Error before error-handling is initialized:

**********************************************************************

Running ./sage -b doesn't really do much, could there be some dependencies missing?

[vbraun]

comment:6

LibGAP needs to be kept in sync since it uses the GAP library from the stand-alone GAP install. I can update libgap...

[jdemeyer]

comment:7

Replying to @vbraun:

LibGAP needs to be kept in sync since it uses the GAP library from the stand-alone GAP install. I can update libgap...

OK, sounds good.

[vbraun]

comment:8

• The gap_packages and database_gap spkgs might need to be updated.
• Changes are not checked in

[vbraun]

comment:9

I've added the corresponding libgap spkg. I didn't make any real changes, only applied the GAP 4.5.7->4.6.2 diffs.

[vbraun]

Changed author from Jeroen Demeyer to Jeroen Demeyer, Volker Braun

[vbraun]

comment:11

For the record: I based the libgap spkg on the libgap version that awaits review at #14014.

There are a few doctests that fail because of changed GAP notation for some group elements.

[vbraun]

Dependencies: #14014

[jdemeyer]

comment:14

Does this really depend on #14014? If not, could you upgrade the libGAP spkg to 4.6.3?

[vbraun]

comment:16

gap, libgap, database_gap, and gap_packages must be kept in sync.

[jdemeyer]

comment:18

Replying to @vbraun:

gap, libgap, database_gap, and gap_packages must be kept in sync.

Sure. I can do all packages except for libGAP.

[vbraun]

comment:19

The patch depends on #14014

[vbraun]

comment:21

The siginterrupt.patch has been upstreamed

[vbraun]

Attachment: trac_14039_doctest_fixes.patch.gz

Updated patch

[vbraun]

comment:22

All doctests pass for me...

[SnarkBoojum]

comment:23

I combined those packages and patches with those of ticket #14014, and things compile and doctest (except the quadratic forms ones which fail on this box anyway).

I'm not sure I can give a positive review though: the patches change the result of many tests, and I have no idea if they really replace a correct value by another correct value...

[vbraun]

comment:24

Superseded by #14682

[tscrim]

Changed author from Jeroen Demeyer, Volker Braun to none

[tscrim]

Reviewer: Travis Scrimshaw