Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "tar", not "cp -pPRL", to copy files in sage-bdist #14236

Closed
jdemeyer opened this issue Mar 6, 2013 · 9 comments
Closed

Use "tar", not "cp -pPRL", to copy files in sage-bdist #14236

jdemeyer opened this issue Mar 6, 2013 · 9 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Mar 6, 2013

After unpacking a binary built using #6495, the various files doc/en/reference/MODULE/conf.py, which are all supposed to by symlinks to doc/en/reference/conf_sub.py, are copies of that file instead, and the hg repo is not clean. So I'm marking this as a blocker.

Related: #14166.

Apply attachment: 14236_bdist.patch local/bin.

CC: @jhpalmieri

Component: scripts

Author: Jeroen Demeyer

Reviewer: John Palmieri

Merged: sage-5.8.beta4

Issue created by migration from https://trac.sagemath.org/ticket/14236

@jdemeyer jdemeyer added this to the sage-5.8 milestone Mar 6, 2013
@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

jdemeyer commented Mar 6, 2013

Author: Jeroen Demeyer

@jhpalmieri
Copy link
Member

comment:3

The patch looks okay to me, and it seems to work, although I have a bit more testing to do.

Unrelated to this patch, but related to sage-bdist: running sage-bdist does not produce the link as given by ln -s local/share "$SAGE_ROOT/data" in spkg/install. Can that cause problems?

@jdemeyer
Copy link
Author

jdemeyer commented Mar 6, 2013

comment:4

Replying to @jhpalmieri:

Unrelated to this patch, but related to sage-bdist: running sage-bdist does not produce the link as given by ln -s local/share "$SAGE_ROOT/data" in spkg/install. Can that cause problems?

Unrelated indeed, but that should also be fixed.

@jhpalmieri
Copy link
Member

comment:5

Attachment: 14236_bdist.patch.gz

This looks good to me. I'll try it out on OpenSolaris just to make sure. By the way, is there a good reason why the symbolic link data is not in the root repo?

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@jdemeyer
Copy link
Author

jdemeyer commented Mar 7, 2013

comment:7

I also added a check in the release management script that the bdist repositories are clean (i.e. hg status shows nothing). This would prevent this problem in the future.

@jdemeyer
Copy link
Author

jdemeyer commented Mar 7, 2013

Merged: sage-5.8.beta4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants