-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloning doesn't properly copy the _static doc directory #14245
Comments
This comment has been minimized.
This comment has been minimized.
Author: John Palmieri |
Changed keywords from _static to _static clone |
comment:3
I think this patch will fix the problem. I also think that the sage-clone script could use some attention in general, but now is not the time. |
comment:4
I'm testing this patch currently but I think I'll give it positive review. Florent |
comment:5
Hum ! The problem of copying the
and indeed the doc is empty. This should also be fixed. I'm investigating for the cause. |
comment:6
Ok ! I think I got it. During cloning the directories such as
are note copied. Sorry I have to go to bed... I'll fix this tomorrow if no one beats me. |
comment:7
Sorry, I missed that. Here's a better attempt. |
scripts repo |
comment:8
Attachment: trac_14245_clone.patch.gz Looks good to me. Thanks ! |
This comment has been minimized.
This comment has been minimized.
Reviewer: Florent Hivert |
comment:9
I wonder if we should (on another ticket, like #13245) also disable docbuilding altogether when cloning... |
comment:10
Replying to @jhpalmieri:
+N |
Merged: sage-5.8.rc0 |
When cloning Sage (eg: for combinat), the doc is copied but not properly:
Before the clone in
doc/output/html/en/reference/numerical
there is a symlink_static
to../_static
. After the clone, it is an empty directory. Also the directories such asare note copied at all.
CC: @jhpalmieri @nexttime @nilesjohnson @hivert @mguaypaq @mwhansen
Component: documentation
Keywords: _static clone
Author: John Palmieri
Reviewer: Florent Hivert
Merged: sage-5.8.rc0
Issue created by migration from https://trac.sagemath.org/ticket/14245
The text was updated successfully, but these errors were encountered: