Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement extracting symbolic coefficient of rational exponent #19996

Closed
dkrenn opened this issue Feb 1, 2016 · 17 comments
Closed

Implement extracting symbolic coefficient of rational exponent #19996

dkrenn opened this issue Feb 1, 2016 · 17 comments

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Feb 1, 2016

sage: (x^(1/2)).coefficient(x, 1/3)
sqrt(x)

It seems that 1/3 gets 0 (floor division, whyever).

EDIT: because the function takes an integer:

        INPUT:

        - ``s`` - expression

        - ``n`` - integer, default 1

so it's rather an enhancement.

Reported as pynac/pynac#216

Depends on #23820

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 6d8d994

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/19996

@dkrenn dkrenn added this to the sage-7.1 milestone Feb 1, 2016
@rwst
Copy link

rwst commented Nov 20, 2016

Upstream: Reported upstream. Developers acknowledge bug.

@rwst

This comment has been minimized.

@rwst

This comment has been minimized.

@rwst
Copy link

rwst commented Nov 25, 2016

Changed upstream from Reported upstream. Developers acknowledge bug. to Reported upstream. Developers deny it's a bug.

@rwst rwst changed the title wrong result extracting symbolic coefficient (rational exponent) Implement extracting symbolic coefficient of rational exponent Nov 25, 2016
@rwst
Copy link

rwst commented Aug 11, 2017

@rwst
Copy link

rwst commented Aug 11, 2017

Changed upstream from Reported upstream. Developers deny it's a bug. to Fixed upstream, in a later stable release.

@rwst
Copy link

rwst commented Aug 11, 2017

comment:4

This branch needs pynac-0.7.11+ and allows any coefficient. There is different behaviour in this doctest:

             sage: f = (a*sqrt(2))*x^2 + sin(y)*x^(1/2) + z^z
...
             sage: f.coefficient(x, 0)
-            sqrt(x)*sin(y) + z^z
+            z^z

New commits:

484142a19996: allow any n in ex.coefficient(x,n)

@rwst
Copy link

rwst commented Aug 11, 2017

Author: Ralf Stephan

@rwst
Copy link

rwst commented Aug 11, 2017

Commit: 484142a

@rwst
Copy link

rwst commented Aug 11, 2017

Dependencies: pynac-0.7.11

@rwst rwst modified the milestones: sage-7.1, sage-8.1 Aug 11, 2017
@rwst
Copy link

rwst commented Sep 10, 2017

Changed upstream from Fixed upstream, in a later stable release. to none

@rwst
Copy link

rwst commented Sep 10, 2017

Changed dependencies from pynac-0.7.11 to #23820

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 23, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

6d8d994Merge branch 'develop' into t/19996/implement_extracting_symbolic_coefficient_of_rational_exponent

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 23, 2017

Changed commit from 484142a to 6d8d994

@tscrim
Copy link
Collaborator

tscrim commented Sep 24, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 24, 2017

comment:8

LGTM.

@vbraun
Copy link
Member

vbraun commented Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants