Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pynac-0.6.4 #20134

Closed
rwst opened this issue Feb 29, 2016 · 21 comments
Closed

Upgrade to pynac-0.6.4 #20134

rwst opened this issue Feb 29, 2016 · 21 comments

Comments

@rwst
Copy link

rwst commented Feb 29, 2016

Newest pynac does:

https://github.com/pynac/pynac/releases/download/pynac-0.6.4/pynac-0.6.4.tar.bz2

Component: packages: standard

Author: Ralf Stephan

Branch/Commit: 9cbedc7

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/20134

@rwst rwst added this to the sage-7.1 milestone Feb 29, 2016
@rwst
Copy link
Author

rwst commented Feb 29, 2016

Branch: u/rws/upgrade_to_pynac_0_6_3

@rwst
Copy link
Author

rwst commented Feb 29, 2016

Commit: 2fab819

@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Feb 29, 2016

New commits:

9db23depackage version / checksum
7785109coth/acoth BuiltinFunction --> GinacFunction and fixes
2fab819doctest fixes

@rwst
Copy link
Author

rwst commented Feb 29, 2016

Author: Ralf Stephan

@behackl
Copy link
Member

behackl commented Mar 3, 2016

comment:3

The interface changes on this ticket are relatively straightforward, and I could easily review this. However, I'm not sure whether I should, as I've contributed to the pynac release. What do you think?

@rwst
Copy link
Author

rwst commented Mar 4, 2016

comment:4

In principle I have already had a look at your changes, but I would like to see a third opinion as well.

@rwst
Copy link
Author

rwst commented Mar 5, 2016

Changed branch from u/rws/upgrade_to_pynac_0_6_3 to u/rws/20134-1

@rwst
Copy link
Author

rwst commented Mar 5, 2016

Changed commit from 2fab819 to f061a28

@rwst
Copy link
Author

rwst commented Mar 5, 2016

New commits:

fcb8d95a42f798 still fails three in expression.pyx
bf73f41adapt doctest to have a different arcsech() expression
65023a5Merge branch 'develop' into for-pynac-0.6.3
1de52c3expand doctest change
075374fadd doctest
6af66d6add doctests for issue 144
1f61a24sech/csch changes
f061a28pynac-0.6.4 pkg version/chksum

@rwst

This comment has been minimized.

@rwst rwst changed the title Upgrade to pynac-0.6.3 Upgrade to pynac-0.6.4 Mar 5, 2016
@jdemeyer
Copy link

jdemeyer commented Mar 5, 2016

comment:7

The whole point of this doctest is lost:

        Here arccoth doesn't have 1 in its domain, so we just hold the expression:

            sage: elliptic_e(arccoth(1), x^2*e)
            elliptic_e(arccoth(1), x^2*e)

I would remove the sentence "Here arccoth doesn't have 1 in its domain, so we just hold the expression:"

@rwst

This comment has been minimized.

@jdemeyer
Copy link

comment:9

Unless I'm missing something, this doctest looks gone:

            sage: diff(asech(x), x)
            -1/((x + 1)*x*sqrt(-(x - 1)/(x + 1)))

@jdemeyer
Copy link

comment:10

Don't forget [comment:7]

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 16, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

0791a61Merge branch 'develop' into t/20134/20134-1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 16, 2016

Changed commit from f061a28 to 0791a61

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 16, 2016

Changed commit from 0791a61 to 9cbedc7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 16, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

9cbedc720134: fix/add doctests

@rwst rwst modified the milestones: sage-7.1, sage-7.2 Mar 16, 2016
@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@vbraun
Copy link
Member

vbraun commented Mar 20, 2016

Changed branch from u/rws/20134-1 to 9cbedc7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants