-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to pynac-0.6.4 #20134
Comments
Branch: u/rws/upgrade_to_pynac_0_6_3 |
Commit: |
This comment has been minimized.
This comment has been minimized.
Author: Ralf Stephan |
comment:3
The interface changes on this ticket are relatively straightforward, and I could easily review this. However, I'm not sure whether I should, as I've contributed to the pynac release. What do you think? |
comment:4
In principle I have already had a look at your changes, but I would like to see a third opinion as well. |
Changed branch from u/rws/upgrade_to_pynac_0_6_3 to u/rws/20134-1 |
New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:7
The whole point of this doctest is lost:
I would remove the sentence "Here arccoth doesn't have 1 in its domain, so we just hold the expression:" |
This comment has been minimized.
This comment has been minimized.
comment:9
Unless I'm missing something, this doctest looks gone:
|
comment:10
Don't forget [comment:7] |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Jeroen Demeyer |
Changed branch from u/rws/20134-1 to |
Newest pynac does:
Re/Im(tanh)
(doctest fix for: Re/Im(tanh) wrong formula #20098) (R. Stephan)2*pi
(test improved evaluation of trigonometric functions and complex exponential function #20099) (B. Hackl)2*pi*I
(test improved evaluation of trigonometric functions and complex exponential function #20099) (B. Hackl)https://github.com/pynac/pynac/releases/download/pynac-0.6.4/pynac-0.6.4.tar.bz2
Component: packages: standard
Author: Ralf Stephan
Branch/Commit:
9cbedc7
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/20134
The text was updated successfully, but these errors were encountered: