-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RealSet: add methods closure, interior, boundary, is_open, is_closed #21243
Comments
This comment has been minimized.
This comment has been minimized.
Dependencies: #31880 |
New commits:
|
Author: Matthias Koeppe |
Commit: |
comment:7
Could you also add a test:
Other than that, LGTM. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: Travis Scrimshaw |
comment:9
Thank you. |
comment:10
Thanks for reviewing! |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:12
(as requested in #31927 comment:8) |
Changed branch from u/mkoeppe/realset__add_methods_closure__interior__boundary__is_open__is_closed to |
The intervals in a
RealSet
already have these methods.It would also be nice to be able to compute closure and interior relative to a given larger
RealSet
.One could also imagine that these should be methods of the real fields (such as RR) considered as a members of the category
TopologicalSpaces
.Depends on #31880
CC: @rwst @vbraun @pjbruin @tscrim @mjungmath @yuan-zhou
Component: basic arithmetic
Author: Matthias Koeppe
Branch/Commit:
9d41f0e
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/21243
The text was updated successfully, but these errors were encountered: