Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RealSet: add methods closure, interior, boundary, is_open, is_closed #21243

Closed
mkoeppe opened this issue Aug 13, 2016 · 18 comments
Closed

RealSet: add methods closure, interior, boundary, is_open, is_closed #21243

mkoeppe opened this issue Aug 13, 2016 · 18 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 13, 2016

The intervals in a RealSet already have these methods.

It would also be nice to be able to compute closure and interior relative to a given larger RealSet.

sage: RealSet((1, 2)).closure(relative_to=RealSet((0, 2))  # wishful thinking
[1, 2)

One could also imagine that these should be methods of the real fields (such as RR) considered as a members of the category TopologicalSpaces.

Depends on #31880

CC: @rwst @vbraun @pjbruin @tscrim @mjungmath @yuan-zhou

Component: basic arithmetic

Author: Matthias Koeppe

Branch/Commit: 9d41f0e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21243

@mkoeppe mkoeppe added this to the sage-7.4 milestone Aug 13, 2016
@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title RealSet: add closure and interior methods RealSet: add methods closure, interior, boundary, is_open, is_closed Aug 18, 2016
@mkoeppe mkoeppe modified the milestones: sage-7.4, sage-9.4 May 30, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 30, 2021

Dependencies: #31880

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 30, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 30, 2021

New commits:

5b8cecaInternalRealInterval, RealSet: Add `_latex_` methods
69ca854RealSet._repr_: Use unicode cup sign instead of +
dbdfc06InternalRealInterval, RealSet: Remove extra whitespace in latex, add documentation
a0e3bf5Merge #31880
181b128RealSet.is_open, is_closed, closure, interior, boundary: New

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 30, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 30, 2021

Commit: 181b128

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

7f56338PiecewiseFunction: Adjust doctests for changed RealSet repr
8cd74b5Merge #31880

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2021

Changed commit from 181b128 to 8cd74b5

@tscrim
Copy link
Collaborator

tscrim commented May 30, 2021

comment:7

Could you also add a test:

RealSet((1, 2), (2, 3)).boundary()

Other than that, LGTM.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2021

Changed commit from 8cd74b5 to 8fdb104

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8fdb104RealSet.boundary: Add another doctest

@tscrim
Copy link
Collaborator

tscrim commented May 31, 2021

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented May 31, 2021

comment:9

Thank you.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 31, 2021

comment:10

Thanks for reviewing!

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 10, 2021

Changed commit from 8fdb104 to 9d41f0e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 10, 2021

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

9d41f0esrc/sage/sets/real_set.py: Remove unnecessary import

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 10, 2021

comment:12

(as requested in #31927 comment:8)

@vbraun
Copy link
Member

vbraun commented Jun 29, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants