Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sqrt products simplification #22621

Open
rwst opened this issue Mar 16, 2017 · 4 comments
Open

Improve sqrt products simplification #22621

rwst opened this issue Mar 16, 2017 · 4 comments

Comments

@rwst
Copy link

rwst commented Mar 16, 2017

Let the argument be positive. I think the following should give sqrt(6), and 6*sqrt(2) respectively.

sage: (sqrt(2) * sqrt(3)).simplify_full()
sqrt(3)*sqrt(2)
sage: (sqrt(12) * sqrt(6)).simplify_full()
2*sqrt(6)*sqrt(3)

There is a Pynac ticket for this but we appreciate improvements of Maxima as well.

CC: @orlitzky

Component: calculus

Issue created by migration from https://trac.sagemath.org/ticket/22621

@rwst rwst added this to the sage-7.6 milestone Mar 16, 2017
@kcrisman
Copy link
Member

comment:1

Is this also going to simplify sqrt(-3)*sqrt(-2)==sqrt(6)? We've had this discussion before...

@rwst
Copy link
Author

rwst commented Mar 18, 2017

comment:2

Replying to @kcrisman:

Is this also going to simplify sqrt(-3)*sqrt(-2)==sqrt(6)? We've had this discussion before...

I don't remember but I hope it concluded that combining positive arguments is fine.

@rwst

This comment has been minimized.

@kcrisman
Copy link
Member

comment:3

#12737 is the main place this sort of thing was discussed, though there are many. Probably for positive is fine, but I'm no expert on this kind of thing.

@mkoeppe mkoeppe removed this from the sage-7.6 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants