Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default implementation of inverse_of_unit() #23191

Closed
saraedum opened this issue Jun 9, 2017 · 12 comments
Closed

default implementation of inverse_of_unit() #23191

saraedum opened this issue Jun 9, 2017 · 12 comments

Comments

@saraedum
Copy link
Member

saraedum commented Jun 9, 2017

Not all ring elements provide inverse_of_unit()

sage: R.<x> = ZZ[]
sage: S = R.quo(x^2 + x + 1)
sage: S(1).inverse_of_unit()
NotImplementedError

But we could always try to invert and see if the result is in the same parent.

Component: commutative algebra

Keywords: sd86.5

Author: Julian Rüth

Branch/Commit: baee716

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/23191

@saraedum
Copy link
Member Author

saraedum commented Jun 9, 2017

@saraedum
Copy link
Member Author

saraedum commented Jun 9, 2017

New commits:

ac3c3f8Add a default implementation of inverse_of_unit() for rings

@saraedum
Copy link
Member Author

saraedum commented Jun 9, 2017

Commit: ac3c3f8

@saraedum
Copy link
Member Author

saraedum commented Jun 9, 2017

Author: Julian Rüth

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2017

Changed commit from ac3c3f8 to 4c1dee4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 9, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4c1dee4Add a default implementation of inverse_of_unit() for rings

@saraedum

This comment has been minimized.

@roed314
Copy link
Contributor

roed314 commented Jun 9, 2017

@roed314
Copy link
Contributor

roed314 commented Jun 9, 2017

comment:6

I fixed a couple doctests (and ran all tests). Looks good.


New commits:

baee716Add inverse_of_unit to list of methods in polynomial quotient ring

@roed314
Copy link
Contributor

roed314 commented Jun 9, 2017

Changed commit from 4c1dee4 to baee716

@jdemeyer
Copy link

Reviewer: David Roe

@vbraun
Copy link
Member

vbraun commented Jun 15, 2017

Changed branch from u/roed/default_implementation_of_inverse_of_unit__ to baee716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants