-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Cython fixes to IndexedFreeModuleElement #23440
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
New commits:
|
Commit: |
Reviewer: Travis Scrimshaw |
comment:5
LGTM. Thank you for cleaning it up. The last part is also useful for #22591 (although I think there is more of a shortcomming of |
Changed branch from u/jdemeyer/various_cython_fixes_to_indexedfreemoduleelement to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
__div__ = __truediv__
is a bad idea for extension types because it acts on the Python method level and not on the slot level:IndexedFreeModuleElement
andLieAlgebraElement
implement arithmetic methods ascdef _add_
while every other class in Sage usescpdef _add_
.six
is slow and should be avoided.IndexedFreeModuleElement
must inherit fromModuleElement
. This is because it uses thecpdef _lmul_
andcpdef _rmul_
which are provided byModuleElement
but not byElement
. This causes trouble forFreeAlgebraElement
which inherits fromIndexedFreeModuleElement
andAlgebraElement
.CC: @tscrim @nthiery
Component: cython
Author: Jeroen Demeyer
Branch/Commit:
8120246
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/23440
The text was updated successfully, but these errors were encountered: