Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctest: Bug in symbolic GCD computations involving complex I #23793

Closed
rwst opened this issue Sep 6, 2017 · 17 comments
Closed

Doctest: Bug in symbolic GCD computations involving complex I #23793

rwst opened this issue Sep 6, 2017 · 17 comments

Comments

@rwst
Copy link

rwst commented Sep 6, 2017

For example gcd(I-I*x, x^2-1) will raise a runtime error (because I cannot be converted to Singular by Pynac).

Depends on #23950

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 638a14b

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23793

@rwst rwst added this to the sage-8.1 milestone Sep 6, 2017
@rwst
Copy link
Author

rwst commented Sep 6, 2017

@rwst
Copy link
Author

rwst commented Sep 6, 2017

Author: Ralf Stephan

@rwst
Copy link
Author

rwst commented Sep 6, 2017

Commit: dd43864

@rwst
Copy link
Author

rwst commented Sep 6, 2017

New commits:

dd4386423793: Fall back to Maxima with some symbolic GCD computations

@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Oct 2, 2017

Changed branch from u/rws/fall_back_to_maxima_with_some_symbolic_gcd_computations to none

@rwst
Copy link
Author

rwst commented Oct 2, 2017

Changed author from Ralf Stephan to none

@rwst
Copy link
Author

rwst commented Oct 2, 2017

Changed commit from dd43864 to none

@rwst
Copy link
Author

rwst commented Oct 2, 2017

Dependencies: #23950

@rwst
Copy link
Author

rwst commented Oct 2, 2017

comment:3

Actually this is resolved in Pynac-0.7.12 and just needs a doctest.

@rwst rwst changed the title Fall back to Maxima with some symbolic GCD computations Doctest: Bug in symbolic GCD computations involving complex I Oct 2, 2017
@rwst
Copy link
Author

rwst commented Oct 24, 2017

Branch: u/rws/23793

@rwst
Copy link
Author

rwst commented Oct 24, 2017

Commit: 638a14b

@rwst
Copy link
Author

rwst commented Oct 24, 2017

New commits:

638a14b23793: Doctest fix for GCD bug

@rwst
Copy link
Author

rwst commented Oct 24, 2017

Author: Ralf Stephan

@tscrim
Copy link
Collaborator

tscrim commented Oct 25, 2017

comment:6

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 25, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Oct 29, 2017

Changed branch from u/rws/23793 to 638a14b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants