Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coercion to fraction field is injective #23965

Closed
saraedum opened this issue Oct 5, 2017 · 14 comments
Closed

Coercion to fraction field is injective #23965

saraedum opened this issue Oct 5, 2017 · 14 comments

Comments

@saraedum
Copy link
Member

saraedum commented Oct 5, 2017

Currently this coercion is not detected as being injective:

sage: R=ZpFM(3)
sage: K=R.fraction_field()
sage: K.coerce_map_from(R).is_injective()
NotImplementedError

Depends on #23510

Component: padics

Author: Julian Rüth

Branch/Commit: a4d9ad6

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/23965

@saraedum saraedum added this to the sage-8.1 milestone Oct 5, 2017
@saraedum
Copy link
Member Author

saraedum commented Oct 5, 2017

@saraedum
Copy link
Member Author

saraedum commented Oct 5, 2017

Commit: 55b33e4

@saraedum

This comment has been minimized.

@saraedum
Copy link
Member Author

saraedum commented Oct 5, 2017

New commits:

55b33e4Coercions to the fraction field are injective

@saraedum
Copy link
Member Author

saraedum commented Oct 5, 2017

Author: Julian Rüth

@saraedum
Copy link
Member Author

saraedum commented Oct 5, 2017

Dependencies: #23510

@roed314
Copy link
Contributor

roed314 commented Oct 5, 2017

@roed314
Copy link
Contributor

roed314 commented Oct 5, 2017

Changed commit from 55b33e4 to a4d9ad6

@roed314
Copy link
Contributor

roed314 commented Oct 5, 2017

comment:7

I merged in #23510 and added a try/except block around the call to fraction_field(), since this can raise a TypeError. If you're happy with this change, positive review once tests pass.


Last 10 new commits:

cb882fdUpdate add_bigoh to account for fixed-mod having a fraction field
a826978Fix _tester_add_bigoh
883e6b5Fix doctest in local_generic_element.pyx
52cbd2aMerge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
bc59ffaMerge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23510/fixed_mod_frac_field
3292259Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
dad02c7Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
189ac2bAdd _test_fraction_field to the coercion tutorial
df62c48Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23965/fracfield_coercion_injective
a4d9ad6Catch exceptions raised by attempting to find fraction field

@saraedum
Copy link
Member Author

saraedum commented Oct 6, 2017

Reviewer: David Roe

@saraedum
Copy link
Member Author

saraedum commented Oct 6, 2017

Work Issues: doctests pass ⇒ positive review

@roed314
Copy link
Contributor

roed314 commented Oct 6, 2017

Changed work issues from doctests pass ⇒ positive review to none

@roed314
Copy link
Contributor

roed314 commented Oct 6, 2017

comment:9

Tests pass.

@vbraun
Copy link
Member

vbraun commented Oct 15, 2017

Changed branch from u/roed/coercion_to_fraction_field_is_injective to a4d9ad6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants