Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove a deprecated method in matrix_space #26555

Closed
fchapoton opened this issue Oct 25, 2018 · 9 comments
Closed

remove a deprecated method in matrix_space #26555

fchapoton opened this issue Oct 25, 2018 · 9 comments
Labels
c: linear algebra p: major / 3 t: enhancement
Milestone
sage-8.5

Comments

@fchapoton
Copy link
Contributor

after #15801

plus a few minor doc details

Component: linear algebra

Author: Frédéric Chapoton

Branch/Commit: c6e5dc7

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26555
@fchapoton fchapoton added this to the sage-8.5 milestone Oct 25, 2018
@fchapoton
Copy link
Contributor Author

Commit: 77767df

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/26555

@fchapoton
Copy link
Contributor Author

New commits:

77767dfremove a deprecated method in matrix_space

@tscrim
Copy link
Collaborator

tscrim commented Oct 26, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 26, 2018

comment:2

LGTM modulo trivial failures in

sage -t --long src/doc/en/thematic_tutorials/coercion_and_categories.rst  # 2 doctests failed

Once fixed, you can set a positive review on my behalf.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2018

Changed commit from 77767df to c6e5dc7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

c6e5dc7trac 26555 fixing doctests

@fchapoton
Copy link
Contributor Author

comment:4

thanks, done. Setting to positive.

@vbraun
Copy link
Member

vbraun commented Oct 28, 2018

Changed branch from u/chapoton/26555 to c6e5dc7

@vbraun vbraun closed this as completed in 73b3b40 Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: linear algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton