Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jupyter notebook to latest (6.1.1) and its dependencies to latest #26919

Closed
slel opened this issue Dec 20, 2018 · 70 comments
Closed

Upgrade Jupyter notebook to latest (6.1.1) and its dependencies to latest #26919

slel opened this issue Dec 20, 2018 · 70 comments

Comments

@slel
Copy link
Member

slel commented Dec 20, 2018

Upgrade:

New dependencies:

  • argon2-cffi (?)
  • pyrsistent, attrs, importlib_metadata, zipp

Upgrade of its dependencies:

Recursive dependencies:

Upgrade of a reverse dependency:

(tarball URLs: see checksums.ini; use ./configure --enable-download-from-upstream-url to enable automatic downloads of the new versions)

Previous upgrades:

See also:

Depends on #28197
Depends on #30299
Depends on #25363

CC: @antonio-rojas @kiwifb @bryangingechen @timokau @infinity0 @jdemeyer @slel @tobihan @egourgoulhon

Component: packages: standard

Keywords: upgrade, jupyter, notebook

Author: Matthias Koeppe, Joshua Campbell

Branch/Commit: 445c1d7

Reviewer: Joshua Campbell, Matthias Koeppe, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/26919

@slel slel added this to the sage-8.6 milestone Dec 20, 2018
@embray
Copy link
Contributor

embray commented Jan 15, 2019

comment:1

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

@embray embray modified the milestones: sage-8.6, sage-8.7 Jan 15, 2019
@embray
Copy link
Contributor

embray commented Mar 25, 2019

comment:2

Moving all blocker/critical issues from 8.7 to 8.8.

@embray embray modified the milestones: sage-8.7, sage-8.8 Mar 25, 2019
@slel

This comment has been minimized.

@slel slel changed the title Upgrade to Jupyter notebook 5.7.4 Upgrade to Jupyter notebook 5.7.7 Mar 29, 2019
@slel

This comment has been minimized.

@slel slel changed the title Upgrade to Jupyter notebook 5.7.7 Upgrade to Jupyter notebook 5.7.8 Apr 14, 2019
@slel
Copy link
Member Author

slel commented Apr 14, 2019

Branch: u/slelievre/notebook-5.7.8

@slel
Copy link
Member Author

slel commented Apr 14, 2019

New commits:

b1a4b7fUpgrade to notebook 5.7.8

@slel
Copy link
Member Author

slel commented Apr 14, 2019

Commit: b1a4b7f

@embray
Copy link
Contributor

embray commented Apr 24, 2019

comment:7

Note, this would conflict slightly with #27715. As this ticket came first I'd be happy to rebase onto it so long as do intend to move forward on this ticket (I don't see why we shouldn't, though I haven't tested it yet...)

@embray
Copy link
Contributor

embray commented Jul 3, 2019

comment:8

Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically).

@embray embray modified the milestones: sage-8.8, sage-8.9 Jul 3, 2019
@fchapoton
Copy link
Contributor

comment:9

branch is red

@embray
Copy link
Contributor

embray commented Dec 30, 2019

comment:11

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-8.9, sage-9.1 Dec 30, 2019
@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 May 4, 2020
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 9, 2020

Changed commit from 0a6487c to af85282

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 9, 2020

comment:43

I've merged your commit. Please test again...

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 9, 2020

comment:45

A build test is running at https://github.com/mkoeppe/sage/actions/runs/201573039

@jcamp0x2a
Copy link
Mannequin

jcamp0x2a mannequin commented Aug 9, 2020

comment:46

Replying to @mkoeppe:

Yes, runtime dependencies should be added in the dependencies file. We do not really distinguish build dependencies and runtime dependencies in the Sage distribution. (There is a notion of order-only dependencies, which are listed after the vertical-bar symbol (|), but it's OK to ignore.)

Ok, I've added dependencies on attrs, importlib_metadata, and pyrsistent to jsonschema and a dependency on zipp to importlib_metadata. (I mispoke earlier that it was required by pyrsistent.) I will update the ticket with the branch.

Also, I want to mention that the latest version of zipp (3.1.0) did not build correctly in the Sage environment, and I didn't do much troubleshooting on it, falling back instead to the specific major and minor version called out by importlib_metadata (0.5, so I used 0.5.2). Just in case that comes up in the future.

@jcamp0x2a
Copy link
Mannequin

jcamp0x2a mannequin commented Aug 9, 2020

comment:47

Replying to @mkoeppe:

Replying to @jcamp0x2a:

I see 404 status codes for /nbextensions/mathjax/MathJax.js?config=TeX-AMS-MML_HTMLorMML-full,Safe&delayStartupUntil=configured and /nbextensions/jsmol/JSmol.min.js, which are perhaps related to some of the other outstanding Jupyter tickets.

OK, I forgot to push the merge with #30299 -- sorry about that

I've tested this again following your merge and both JSmol and MathJax are now working correctly.

@jcamp0x2a
Copy link
Mannequin

jcamp0x2a mannequin commented Aug 9, 2020

Changed branch from u/mkoeppe/notebook-5.7.8 to u/gh-jcamp0x2a/notebook-5.7.8

@jcamp0x2a
Copy link
Mannequin

jcamp0x2a mannequin commented Aug 9, 2020

Changed commit from af85282 to d7d995d

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 9, 2020

Changed author from Matthias Koeppe to Matthias Koeppe, Joshua Campbell

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 9, 2020

comment:49

Thanks very much! Looking great.

I have restarted the build tests, now at https://github.com/mkoeppe/sage/actions/runs/201611495

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 10, 2020

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 10, 2020

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2020

Changed reviewer from Joshua Campbell, ​https://github.com/mkoeppe/sage/actions/runs/201611495 to Joshua Campbell, ​github.com/mkoeppe/sage/actions/runs/201611495, ...

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2020

comment:52

Clean tests for slackware-14.2-standard (https://github.com/mkoeppe/sage/runs/964353866), gentoo-standard (https://github.com/mkoeppe/sage/runs/964353835), fedora-32-standard (https://github.com/mkoeppe/sage/runs/964353804). (Tests on many other platforms did not go through because of current reliability issues of GH Action - unrelated to this ticket.)

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2020

Changed reviewer from Joshua Campbell, ​github.com/mkoeppe/sage/actions/runs/201611495, ... to Joshua Campbell, Matthias Koeppe, ​github.com/mkoeppe/sage/actions/runs/201611495, ...

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2020

Changed branch from u/gh-jcamp0x2a/notebook-5.7.8 to u/mkoeppe/notebook-5.7.8

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2020

Changed dependencies from #28197, #30299 to #28197, #30299, #25363

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2020

Changed commit from d7d995d to 445c1d7

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2020

comment:55

Merged #25363 (and 9.2.beta8) to facilitate testing


New commits:

3b8b2bdtrac 25363: implement "sage --simple-prompt"
445c1d7Merge branch 'u/jhpalmieri/ticket-25363' of git://trac.sagemath.org/sage into t/26919/jupyter-notebook-6.1.1

@dimpase
Copy link
Member

dimpase commented Aug 12, 2020

comment:56

Great!

@dimpase
Copy link
Member

dimpase commented Aug 12, 2020

Changed reviewer from Joshua Campbell, Matthias Koeppe, ​github.com/mkoeppe/sage/actions/runs/201611495, ... to Joshua Campbell, Matthias Koeppe, ​github.com/mkoeppe/sage/actions/runs/201611495, Dima Pasechnik

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2020

comment:57

Thank you!

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 12, 2020

Changed reviewer from Joshua Campbell, Matthias Koeppe, ​github.com/mkoeppe/sage/actions/runs/201611495, Dima Pasechnik to Joshua Campbell, Matthias Koeppe, Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented Aug 15, 2020

Changed branch from u/mkoeppe/notebook-5.7.8 to 445c1d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants