Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pointless comparison doctests in valuations #26934

Closed
jdemeyer opened this issue Dec 21, 2018 · 7 comments
Closed

Remove pointless comparison doctests in valuations #26934

jdemeyer opened this issue Dec 21, 2018 · 7 comments
Labels
c: python3 p: major / 3 t: bug
Milestone
sage-8.6

Comments

@jdemeyer
Copy link

These doctests specifically try to compare uncomparable valuations, which is going to be an error after #22029.

CC: @saraedum

Component: python3

Author: Jeroen Demeyer

Branch/Commit: d7ece06

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/26934
@jdemeyer jdemeyer added this to the sage-8.6 milestone Dec 21, 2018
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/remove_pointless_comparison_doctests_in_valuations

@jdemeyer
Copy link
Author

New commits:

d7ece06Remove pointless comparison doctests in valuations

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Commit: d7ece06

@saraedum
Copy link
Member

comment:4

The clarification is not necessary anymore once #22029 has been merged.

@saraedum
Copy link
Member

Reviewer: Julian Rüth

@vbraun
Copy link
Member

vbraun commented Dec 23, 2018

Changed branch from u/jdemeyer/remove_pointless_comparison_doctests_in_valuations to d7ece06

@vbraun vbraun closed this as completed in c4ea85e Dec 23, 2018
@mezzarobba mezzarobba mentioned this issue Feb 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.6
Development

No branches or pull requests
3 participants
@saraedum @vbraun @jdemeyer