Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnionOfIntervals.__contains__ doctest tests str #26947

Closed
jdemeyer opened this issue Dec 23, 2018 · 7 comments
Closed

UnionOfIntervals.__contains__ doctest tests str #26947

jdemeyer opened this issue Dec 23, 2018 · 7 comments
Labels
c: coercion p: major / 3 t: bug
Milestone
sage-8.6

Comments

@jdemeyer
Copy link

It is documented that the input of __contains__ should be a real number, yet there is this doctest:

            sage: 'a' in A
            False

This will break after #22029.

Since this test is meaningless, it should just be removed.

CC: @JohnCremona

Component: coercion

Author: Jeroen Demeyer

Branch/Commit: 6a8b25b

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/26947
@jdemeyer jdemeyer added this to the sage-8.6 milestone Dec 23, 2018
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/unionofintervals___contains___doctest_tests_str

@jdemeyer
Copy link
Author

New commits:

6a8b25bRemove UnionOfIntervals.__contains__ test with str input

@jdemeyer
Copy link
Author

Commit: 6a8b25b

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@fchapoton
Copy link
Contributor

comment:3

ok

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Dec 30, 2018

Changed branch from u/jdemeyer/unionofintervals___contains___doctest_tests_str to 6a8b25b

@vbraun vbraun closed this as completed in 3d2fa91 Dec 30, 2018
@mezzarobba mezzarobba mentioned this issue Feb 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: coercion p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.6
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton