spkg-configure.m4 for arb

[dimpase]

SAGE_SPKG_CONFIGURE([arb], [
    AC_CHECK_HEADER(arb.h, [], [sage_spkg_install_arb=yes])
dnl below function added in version 2.16 of arb 
    AC_SEARCH_LIBS([acb_mat_eig_simple], [arb], [break], [sage_spkg_install_arb=yes])

we also take care of non-standard naming of arb's dylib here.

configure tarball http://users.ox.ac.uk/~coml0531/sage/configure-b5de8991395bbf58e663e69d6250de656897c4e2.tar.gz

Upstream: Reported upstream. No feedback yet.

CC: @embray @jdemeyer @tobihan @kiwifb

Component: build

Author: Dima Pasechnik, Isuru Fernando

Branch: 29d4ce2

Reviewer: François Bissey, Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/27270

[dimpase]

Dependencies: #27264

[dimpase]

Commit: 46b529e

[dimpase]

comment:3

this does not implement --with-arb=..., as I hope it's not needed.
And no other packages have --with-arb=, too.

---

Last 10 new commits:

50aebab	implement --with-mpfr=system/install
0fc433f	update for Sage 8.7.rc0, a typo fix
38427e1	spkg-configure for mpc, adjustments for its dependees
ec32471	Merge branch 'u/dimpase/packages/mpc-config' of trac.sagemath.org:sage into mpf
91f423f	rebase, deal with --with-mpc
33edfa8	Merge branch 'mpf' into flintconf - no spkg-configure yet
82772d7	spkg-configure for flint
24f17d5	testi for GC enabled
c1ac4f2	proper nesting of tests
46b529e	spkg-configure for arb

[dimpase]

Branch: u/dimpase/packages/arbconfig

[dimpase]

comment:4

Tests pass, apart from this amusing doctest failure:

File "src/sage/misc/package.py", line 282, in sage.misc.package.installed_packages
Failed example:
    installed_packages()
Expected:
    {...'arb': ...'pynac': ...}
Got:
    {'.dummy': '',
     'alabaster': '0.7.12',
     'appnope': '0.1.0.p0',
...

Less amusing is that with arb manually installed to /usr/local on Gentoo Linux, I get a import error upon Sage startup, from deep inside sagelib.

I have to start Sage as LD_LIBRARY_PATH=/usr/local/lib64 ./sage, otherwise
I get

ImportError: libarb.so.2: cannot open shared object file: No such file or directory

I do have /usr/local/lib64 in /etc/ld.so.conf, by the way.
Does this mean we need do jump through some linking hoops here?

I certainly can add a proper runtime test in spkg-configure.m4, but why?

[dimpase]

comment:5

Replying to @dimpase:

Less amusing is that with arb manually installed to /usr/local on Gentoo Linux, I get a import error upon Sage startup, from deep inside sagelib.

oops, my fault. Forgot to run ldconfig after the installation.
(maybe arb should do it for you, cf. flintlib/arb#273).

[sagetrac-git]

Changed commit from 46b529e to 961886d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

961886d

arb can be dummy, don't mention it in packages doctest

[dimpase]

Upstream: Reported upstream. No feedback yet.

[dimpase]

comment:7

upstream report not directly relevant to this ticket, bit OK.

[embray]

comment:8

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

[sagetrac-git]

Changed commit from 961886d to 7a9c768

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7a9c768

typo in parameter

[sagetrac-git]

Changed commit from 7a9c768 to 1ed5dbb

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

1357bef	implement --with-mpfr=system/install
e7d04e7	spkg-configure for mpc, adjustments for its dependees
fb3aec7	rebase, deal with --with-mpc
30b85f7	spkg-configure for flint
e17167e	testi for GC enabled
d7f3747	proper nesting of tests
88209e0	typo in parameter
329b835	rebase, deal with --with-mpc
447ab2d	spkg-configure for arb
1ed5dbb	arb can be dummy, don't mention it in packages doctest

[dimpase]

comment:11

OK, so this branch has mpfr (#27258)
mpc (#27259)
ntl (#27265)
flint (#27264) and, naturally,
arb. Would be great to have it all reviewed in one go...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c09667d

configure bump

[sagetrac-git]

Changed commit from 1ed5dbb to c09667d

[sagetrac-git]

Changed commit from c09667d to a247437

[sagetrac-git]

comment:13

Attachment: configure-320.tar.gz

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a867838	typo
c4e7778	rebase, deal with --with-mpc
cd15ac1	spkg-configure for arb
07276c8	arb can be dummy, don't mention it in packages doctest
a247437	configure bump

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

0392e76	rebase, deal with --with-mpc
73ce2a9	spkg-configure for flint
37fa1a1	testi for GC enabled
4f6434c	proper nesting of tests
a672706	typo in parameter
013dfbe	typo
e698ffc	corrected rebase
8fc4fb6	add dependency checks, remove unneeded `-with` handling
1ad182d	SAGE_CONFIGURE_MPFR, fix sage-env-config.in, arb can be dummy
9de7419	added dependency check

[sagetrac-git]

Changed commit from f463852 to 166e00c

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

2c4d350	set SAGE_ARB_LIBRARY correctly in every scenario
166e00c	bump up configure

[dimpase]

comment:68

fixing a "minor" m4 error in the latest change.

[antonio-rojas]

comment:69

Could you add a fallback for SAGE_ARB_LIBRARY in env.py? This wouldn't make any difference for users of the Sage build system (since it is set in sage-env-config) or distros that rename the arb library (which need to set it anyway), and would save distros that use the standard arb library name from having to worry about it

--- src/sage/env.py.orig        2019-07-19 14:05:32.947459540 +0200
+++ src/sage/env.py     2019-07-19 14:15:14.193540393 +0200
@@ -406,6 +406,8 @@
     # This is not a problem in practice since LinBox depends on
     # fflas-ffpack and fflas-ffpack does add such a C++11 flag.
     aliases["LINBOX_CFLAGS"].append("-std=gnu++11")
-    aliases["ARB_LIBRARY"] = os.environ['SAGE_ARB_LIBRARY']
-
+    if os.environ.get('SAGE_ARB_LIBRARY'):
+        aliases["ARB_LIBRARY"] = os.environ['SAGE_ARB_LIBRARY']
+    else:
+        aliases["ARB_LIBRARY"] = 'arb'
     return aliases

[sagetrac-git]

Changed commit from 166e00c to 411d4a7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

73dd667	fallback for ARB_LIBRARY in src/sage/env.py
411d4a7	bump up configure

[dimpase]

comment:71

Done the fallback.

[isuruf]

Changed branch from u/dimpase/packages/arbconfig to u/isuruf/arbconfig

[isuruf]

Changed commit from 411d4a7 to 9f79388

[isuruf]

Changed reviewer from François Bissey to François Bissey, Isuru Fernando

[isuruf]

Changed author from Dima Pasechnik to Dima Pasechnik, Isuru Fernando

[dimpase]

Changed commit from 9f79388 to 29d4ce2

[dimpase]

Last 10 new commits:

5aad412	sage should be called with ./ in bootstrap
085f518	Debian names the arb library differently
d24ae0f	mention flint and arb (and one more forgotten package) for debian
2e04b25	add the name of arb dylib to cython_aliases
0e4e71a	use AC_CHECK_LIB() calls, as they can be nested
3e8bd98	pass the name of arb dylib via an environment variable
ce2b9e0	set SAGE_ARB_LIBRARY correctly in every scenario
12f5129	fallback for ARB_LIBRARY in src/sage/env.py
b5de899	make code simpler
29d4ce2	bump up configure

[dimpase]

Changed branch from u/isuruf/arbconfig to u/dimpase/packages/arbconfig

[dimpase]

comment:76

merged u/isuruf/arbconfig (which erroneously contained just 1 commit), rebased over 8.9.beta3, bumpled up configure

[vbraun]

Changed branch from u/dimpase/packages/arbconfig to 29d4ce2

[mkoeppe]

Changed commit from 29d4ce2 to none

[mkoeppe]

comment:78

Recognizing flint-arb here broke the optional package e-antic (used by normaliz). Follow-up = #27952.