Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spkg-configure.m4 for pkgconf #27827

Closed
dimpase opened this issue May 13, 2019 · 19 comments
Closed

spkg-configure.m4 for pkgconf #27827

dimpase opened this issue May 13, 2019 · 19 comments

Comments

@dimpase
Copy link
Member

dimpase commented May 13, 2019

pkgconf is an implementation of widely used pkg-config.
In fact, pkg-config can be configured to look at certain directories, so we can use the one on the system.

This is what the branch does - it check for pkg-config presense,
and if it is there is sets up/updates the env.var. PKG_CONFIG_PATH
in src/bin/sage-env-config. As pkg-config looks in dirs in PKG_CONFIG_PATH first, anything that Sage installs there overrides the system ones.

CC: @embray @kiwifb @isuruf @antonio-rojas

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: ed84fa2

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/27827

@dimpase dimpase added this to the sage-8.8 milestone May 13, 2019
@embray
Copy link
Contributor

embray commented Jun 14, 2019

comment:1

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

@embray embray removed this from the sage-8.8 milestone Jun 14, 2019
@dimpase
Copy link
Member Author

dimpase commented Jul 16, 2019

comment:2

the plan is to install PKG_CONFIG_PATH=SAGE_LOCAL/lib/pkgconfig into src/bin/sage-env-config in case the system has pkg-config installed.

@dimpase dimpase added this to the sage-8.9 milestone Jul 16, 2019
@dimpase
Copy link
Member Author

dimpase commented Jul 18, 2019

New commits:

f77b4c1spkg-configure.m4 for pkgconf

@dimpase
Copy link
Member Author

dimpase commented Jul 18, 2019

Author: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented Jul 18, 2019

Branch: u/dimpase/packages/pkgconf

@dimpase
Copy link
Member Author

dimpase commented Jul 18, 2019

Commit: f77b4c1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 18, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

836f5baspkg-configure.m4 for pkgconf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 18, 2019

Changed commit from f77b4c1 to 836f5ba

@dimpase

This comment has been minimized.

@isuruf
Copy link
Member

isuruf commented Jul 21, 2019

comment:7

Works for me

@isuruf
Copy link
Member

isuruf commented Jul 21, 2019

Reviewer: Isuru Fernando

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2019

Changed commit from 836f5ba to 3b95f60

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2019

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

3b95f60spkg-configure.m4 for pkgconf

@dimpase
Copy link
Member Author

dimpase commented Jul 23, 2019

comment:9

rebased over 8.9.beta3

@vbraun
Copy link
Member

vbraun commented Jul 23, 2019

comment:10

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 29, 2019

Changed commit from 3b95f60 to ed84fa2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 29, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ed84fa2spkg-configure.m4 for pkgconf

@dimpase
Copy link
Member Author

dimpase commented Jul 29, 2019

comment:12

rebased over Sage 8.9.beta4

@vbraun
Copy link
Member

vbraun commented Jul 30, 2019

Changed branch from u/dimpase/packages/pkgconf to ed84fa2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants