spkg-configure.m4 for eclib

[dimpase]

the main issue here is how to check that the version installed on the system is good enough.

We check for a header that only appeared in 2018, that's all we could find atm.

Depends on #28242

Upstream: Reported upstream. No feedback yet.

CC: @embray @kiwifb @isuruf

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: 699f220

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/28333

[dimpase]

Changed upstream from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.

[dimpase]

Dependencies: #28242

[dimpase]

comment:2

while at it, we should fix eclib's spkg-install, which should always have --with-flint, otherwise flint is not linked it (causing worse performance I guess).

[dimpase]

comment:3

see JohnCremona/eclib#56 for the version issue

[dimpase]

Branch: build/pkgs/eclib/spkg-configure.m4

[dimpase]

Author: Dima Pasechnik

[dimpase]

Changed branch from build/pkgs/eclib/spkg-configure.m4 to u/dimpase/packages/eclib-config

[dimpase]

New commits:

2f45c9e	spkg-configure for pari
b622942	spkg-configure for pari_elldata
2e11aed	spkg-configure's for PARI packages
183f47c	check for PARI packages in PARI's spkg-configure
72f3c20	spkg-configure for gp2c
6eac550	as pari might become dummy, test with GAP
ac207d5	don't export GP_DATA_DIR, remove other, unneeded GP* vars
317f090	proper dependency resolution (all tests in PARI spkg-config)
2c26115	docbuild workaround for external PARI
0c8bf98	spkg-configure for eclib

[dimpase]

Commit: 0c8bf98

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e53d6a7	spkg-configure for eclib
6745e5d	use internal or external flint, always

[sagetrac-git]

Changed commit from 0c8bf98 to 6745e5d

[dimpase]

comment:8

The current Debian eclib is too old, one needs to rule it out using something like
JohnCremona/eclib#56 (comment)

---

New commits:

e53d6a7	spkg-configure for eclib
6745e5d	use internal or external flint, always

[sagetrac-git]

Changed commit from 6745e5d to 63ead07

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

63ead07

added test for versions >= v20190226

[dimpase]

comment:11

To test this, I checked that eclib from Debian 10 does not get picked up (as it should be). Then I uninstalled the system's eclib and installed the current eclib into /usr/local (with the configure parameters as in spkg-install), and it got picked up just fine.

[isuruf]

comment:12

configure:12023: /projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/bin/x86_64-conda_cos6-linux-gnu-c++ -std=gnu++11 -o conftest -fvisibility-inlines-hidden -std=c++17 -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -I/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/include -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -I/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/include -Wl,-O2 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--disable-new-dtags -Wl,--gc-sections -L/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/lib -Wl,-rpath,/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/lib -lec conftest.cpp -lmpfr -lgmp -lm  -lntl >&5
/projects/66d93023-00f0-4c12-8a25-5d6d4e486740/sage-build/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld: /tmp/ccEA25VC.o: in function `main':
conftest.cpp:(.text.startup.main+0x11): undefined reference to `show_version()'

Note that -lec comes before conftest.cpp and not after like the other libs.

[sagetrac-git]

Changed commit from 63ead07 to c4665b3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c4665b3

correct LIBS and LDFLAGS to link correctly

[dimpase]

comment:14

OK, I've fixed this, it was a really bad bug there, not the least wrong number of parameters used for AC_RUN_IFELSE.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

dd2b3fa	redirect gp errors to config.log
23f8448	spkg-configure for eclib
af16082	use internal or external flint, always
7a8d11e	added test for versions >= v20190226
699f220	correct LIBS and LDFLAGS to link correctly

[sagetrac-git]

Changed commit from c4665b3 to 699f220

[dimpase]

comment:16

rebased over updated #28242

[isuruf]

comment:17

Works for me in conda

[isuruf]

Reviewer: Isuru Fernando

[vbraun]

Changed branch from u/dimpase/packages/eclib-config to 699f220