Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MR33: Relative Extensions of Finite Fields #28485

Open
sagetrac-gitlab-bot mannequin opened this issue Sep 13, 2019 · 112 comments · May be fixed by #34992
Open

MR33: Relative Extensions of Finite Fields #28485

sagetrac-gitlab-bot mannequin opened this issue Sep 13, 2019 · 112 comments · May be fixed by #34992
Labels
c: finite rings p: major / 3 t: enhancement

Comments

@sagetrac-gitlab-bot
Copy link
Mannequin

sagetrac-gitlab-bot mannequin commented Sep 13, 2019 •
edited by mkoeppe
Loading

supersedes #23316.

The GitLab MR is here: https://gitlab.com/sagemath/sage/-/merge_requests/33

Depends on #21413
Depends on #26105
Depends on #33373

Component: finite rings

Keywords: padicBordeaux

Author: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/28485
@sagetrac-gitlab-bot sagetrac-gitlab-bot mannequin added this to the sage-8.9 milestone Sep 13, 2019
@saraedum

This comment has been minimized.

Sign in to view
@saraedum
Copy link
Member

Changed keywords from none to padicBordeaux

@saraedum
Copy link
Member

Dependencies: #21413, #26105

@saraedum

This comment has been minimized.

Sign in to view
@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Sep 13, 2019

Changed commit from 9cc9805 to 2482826

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Sep 13, 2019

comment:3

New commits added to merge request. I updated the commit SHA-1. Last 10 new commits:

f4f17d6Fix precision problem in vector space maps by using new method _polynomial_list
23947e9Working on vector_space and free_module
8db48a2Reviewer suggestions
79f2458One more Returns
9313b2cAdjust comment
3245229Merge remote-tracking branch 'trac/u/roed/free_module' into finite-field-relative
a78136cMove absolute finte field code to its own base class
92347b4make free_module temporarily work for relative extensions
d044c89Do not hide unrelated ValueError
2482826Adapt to new free_module naming

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Sep 14, 2019

Changed commit from 2482826 to 5e294d5

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Sep 14, 2019

comment:4

New commits added to merge request. I updated the commit SHA-1. Last 10 new commits:

6a52519Merge branch 't/26105/26105_base_hom' into t/21413/21413/class_ring_extension
0433a1amore work on morphisms
e933a5dwrite a factory
ed7c7b6fix variable_name(s)
10cb1f3Merge remote-tracking branch 'trac/u/caruso/21413/class_ring_extension' into finite-field-relative
d0e0953Add base_map to finite_field homsets
c672c0eMerge remote-tracking branch 'trac/u/roed/26105_base_hom' into finite-field-relative
16feb8dFix some errors with positional check arguments
382362dMerge remote-tracking branch 'trac/u/roed/26105_base_hom' into finite-field-relative
5e294d5Cleaning up finite field factory

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Sep 14, 2019

Changed commit from 5e294d5 to 5425868

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Sep 14, 2019

comment:5

New commits added to merge request. I updated the commit SHA-1. New commits:

f5386ecConsistency for change_ring()
5425868Fix extension(absolute=True) for finite fields

@xcaruso
Copy link
Contributor

xcaruso commented Oct 10, 2019

Changed branch from u/galois/mrs/33/finite-field-relative to u/caruso/mrs/33/finite-field-relative

@embray
Copy link
Contributor

embray commented Dec 30, 2019

comment:7

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-8.9, sage-9.1 Dec 30, 2019
@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 6, 2020

Changed commit from 5425868 to ac1add0

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 6, 2020

comment:8

New commits added to merge request. I updated the commit SHA-1. New commits:

ac1add0Merge branch 'develop' into finite-field-relative

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 14, 2020

Changed commit from ac1add0 to ff95a24

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 14, 2020

comment:9

New commits added to merge request. I updated the commit SHA-1. New commits:

76604eeChange emails
ff95a24Make _backend accessible from Python, fix absolute_field and __iter__

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2020

Changed commit from ff95a24 to e92d9ea

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

e92d9eaMerge branch 'u/caruso/mrs/32/finite-field-relative' of git://trac.sagemath.org/sage into relative_extension_finite_fields

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Apr 2, 2020

Changed commit from e92d9ea to 2d46b14

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Apr 2, 2020

comment:11

New commits added to merge request. I updated the commit SHA-1. This was a forced push. New commits:

ac1add0Merge branch 'develop' into finite-field-relative
76604eeChange emails
ff95a24Make _backend accessible from Python, fix absolute_field and __iter__
2d46b14working on relative finite fields

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 14, 2020

comment:12

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 18, 2022

comment:52

New commits added to merge request. I updated the commit SHA-1. New commits:

1f6f02bFixing various subtle bugs
e5e97deMerge branch 'finite-field-relative' of gitlab.com:sagemath/dev/sage into finite-field-relative

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 18, 2022

Changed commit from 3b17346 to e5e97de

@roed314
Copy link
Contributor

roed314 commented Feb 18, 2022

Changed commit from e5e97de to 4174c33

@roed314
Copy link
Contributor

roed314 commented Feb 18, 2022

New commits:

4174c33Merge branch 'develop' into t/28485/mrs/33/finite-field-relative

@roed314
Copy link
Contributor

roed314 commented Feb 18, 2022

Changed dependencies from #21413, #26105 to #21413, #26105, #33373

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 18, 2022

comment:54

New commits added to merge request. I updated the commit SHA-1. This was a forced push. Last 10 new commits:

c44129bFix doctest output for residue rings
b7179f7Do not test for exact factorization
72668c9Fix error reporting for ring extension gens()
18ea144Fixing some finite field tests
1f7d77eMaking tests pass
1f6f02bFixing various subtle bugs
3b17346Testing gitlab comments
e5e97deMerge branch 'finite-field-relative' of gitlab.com:sagemath/dev/sage into finite-field-relative
03a15e1Convert result of multivariate polynomial evaluation into correct parent
8185765Merge branch 't/33373/incorrect_parent_when_evaluating_constant_multivariate_polynomial' into finite-field-relative

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 18, 2022

Changed commit from 4174c33 to 8185765

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 18, 2022

comment:55

New commits added to merge request. I updated the commit SHA-1. New commits:

7624b5dAdd more print statements for ring extension morphisms when broken

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 18, 2022

Changed commit from 8185765 to 7624b5d

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 19, 2022

comment:56

New commits added to merge request. I updated the commit SHA-1. New commits:

69610f0Try a bunch of stuff in RingExtensionHomomorphism.__init__ check. Not sure if it is all a good idea, but it makes a test pass

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 19, 2022

Changed commit from 7624b5d to 69610f0

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 19, 2022

comment:57

New commits added to merge request. I updated the commit SHA-1. New commits:

9bd024dWorking on making finite field tests pass
943c995Pulling ring extension changes out into a separate branch
71b2433Merge branch 'ring-extension-revisions' of gitlab.com:sagemath/dev/sage into finite-field-relative

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 19, 2022

Changed commit from 69610f0 to 71b2433

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 19, 2022

Changed commit from 71b2433 to 55f9854

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 19, 2022

comment:58

New commits added to merge request. I updated the commit SHA-1. New commits:

4332ca7Renaming and deleting files in preparation for switching from Cython to Python
dc7088aRemoving obvious Cythonisms
ad8c74eSome more fixes from Pythonization
8899fb0Fixing some more cythonization problems
41a3a57Fixing some tests
372949aRemoving some finite field changes
8d7afebMerge branch 'ring-extension-revisions' of gitlab.com:sagemath/dev/sage into finite-field-relative
55f9854Putting finite field test fixes back in

@xcaruso
Copy link
Contributor

xcaruso commented Feb 20, 2022

Changed commit from 55f9854 to 4174c33

@xcaruso
Copy link
Contributor

xcaruso commented Feb 20, 2022

comment:59

I made a series of comments on gitlab (nothing very important).

Moreover, I would suggest to add the keyword absolute to the constructor GF (GF(27, absolute=False) would return the relative extension GF(27) over GF(3)) and to the method frobenius_endomorphism which currently always returns the absolute Frobenius.

New commits:

4174c33Merge branch 'develop' into t/28485/mrs/33/finite-field-relative

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 7, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
@sagetrac-akulkarn sagetrac-akulkarn mannequin mentioned this issue Oct 4, 2019
Closed
@saraedum saraedum mentioned this issue Feb 12, 2022
Open
This was referenced Feb 22, 2022
Closed
Open
@tscrim tscrim mentioned this issue Sep 18, 2022
Closed
@roed314 roed314 linked a pull request Feb 6, 2023 that will close this issue
Draft
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 13, 2023

Removed branch from issue description; replaced by PR #34992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: finite rings p: major / 3 t: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finite field relative roed314/sage
6 participants
@roed314 @saraedum @embray @slel @xcaruso @mkoeppe