Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change_ring() should preserve sparsity of vectors and vector spaces #29360

Closed
mwageringel opened this issue Mar 18, 2020 · 12 comments
Closed

change_ring() should preserve sparsity of vectors and vector spaces #29360

mwageringel opened this issue Mar 18, 2020 · 12 comments
Labels
c: linear algebra p: major / 3 t: bug
Milestone
sage-9.8

Comments

@mwageringel
Copy link 

sage: vector(QQ, 10, {0:1}, sparse=True).change_ring(AA).is_sparse()  # should be True
False
sage: VectorSpace(QQ, 10, sparse=True).change_ring(RR).is_sparse()  # should be True
False

The analogous methods for matrices work correctly.

Component: linear algebra

Author: Frédéric Chapoton

Branch/Commit: 5c13b55

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29360
@mwageringel mwageringel added this to the sage-9.1 milestone Mar 18, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 14, 2020

comment:1

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 14, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 29, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 13, 2021

comment:3

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 1, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@fchapoton
Copy link
Contributor

New commits:

f4f2cd3preserve sparsity through change_ring

@fchapoton
Copy link
Contributor

Commit: f4f2cd3

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

Branch: u/chapoton/29360

@tscrim
Copy link
Collaborator

tscrim commented Nov 25, 2022

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Nov 25, 2022

comment:9

Green bot => positive review.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 26, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

5c13b55fix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 26, 2022

Changed commit from f4f2cd3 to 5c13b55

@fchapoton
Copy link
Contributor

comment:11

ok, setting to positive after having fixed the code

@vbraun
Copy link
Member

vbraun commented Dec 11, 2022

Changed branch from u/chapoton/29360 to 5c13b55

@vbraun vbraun closed this as completed in ba1e689 Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: linear algebra p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.8
Development

No branches or pull requests
5 participants
@vbraun @tscrim @fchapoton @mkoeppe @mwageringel