Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have method is_unit of QuotientRingElement and PolynomialQuotientRingElement return True in more cases #29469

Closed
soehms opened this issue Apr 5, 2020 · 11 comments

Comments

@soehms
Copy link
Member

soehms commented Apr 5, 2020

In the case of both classes there are examples where is_unit raises a NotImplementedError even though the answer True could easily be given:

sage: P.<x,y> = QQ[]
sage: Q = P.quo([1-x*y])
sage: Q.inject_variables()
Defining xbar, ybar
sage: ybar.is_unit()
Traceback (most recent call last):
...
NotImplementedError:

but:

sage: ~ybar
xbar

or:

sage: Z16x.<x> = Integers(16)[]
sage: S.<y> =  Z16x.quotient(x^2 + x + 1)
sage: S(3).is_unit()
Traceback (most recent call last):
...
NotImplementedError: The base ring (=Ring of integers modulo 16) is not a field

but:

sage: Z16x(3).is_unit()
True

This will be improved here. Se also this sage-devel thread.

Component: commutative algebra

Keywords: quotient ring, polynomial, is_unit, invert

Author: Sebastian Oehms

Branch/Commit: 0beccc8

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29469

@soehms soehms added this to the sage-9.1 milestone Apr 5, 2020
@soehms
Copy link
Member Author

soehms commented Apr 5, 2020

@soehms
Copy link
Member Author

soehms commented Apr 5, 2020

New commits:

85afe0a29469: initial

@soehms
Copy link
Member Author

soehms commented Apr 5, 2020

Commit: 85afe0a

@soehms
Copy link
Member Author

soehms commented Apr 5, 2020

Author: Sebastian Oehms

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 10, 2020

Changed commit from 85afe0a to 0beccc8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 10, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

0beccc829469: fix doctest in matrix0

@mkoeppe
Copy link
Contributor

mkoeppe commented May 1, 2020

comment:4

Moving tickets to milestone sage-9.2 based on a review of last modification date, branch status, and severity.

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 May 1, 2020
@tscrim
Copy link
Collaborator

tscrim commented May 20, 2020

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 20, 2020

Reviewer: Travis Scrimshaw

@soehms
Copy link
Member Author

soehms commented May 21, 2020

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented May 26, 2020

Changed branch from u/soehms/is_unit_quotient_ring_elemnts_29469 to 0beccc8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants