Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide precious variables (CFLAGS, PKG_CONFIG_PATH, ...) to make #29507

Open
mkoeppe opened this issue Apr 14, 2020 · 7 comments
Open

Provide precious variables (CFLAGS, PKG_CONFIG_PATH, ...) to make #29507

mkoeppe opened this issue Apr 14, 2020 · 7 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 14, 2020

autotools have a concept of "precious variables"
(https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Setting-Output-Variables.html).

Because we do not use automake, many standard precious variables such as CFLAGS, PKG_CONFIG_PATH are not actually applied to building.

This should be fixed to make our build system more standard.

(from discussions in #29504, and a discussion with gh-mwageringel on a ticket I lost track of)

Likewise, for variables set by .homebrew-build-env (https://groups.google.com/d/msg/sage-devel/taOGXzXq6Lk/ePcXsCvhBAAJ)

See also:

CC: @jhpalmieri @mwageringel @dimpase @kiwifb @kliem @dcoudert

Component: build: configure

Keywords: sd111

Issue created by migration from https://trac.sagemath.org/ticket/29507

@mkoeppe mkoeppe added this to the sage-9.2 milestone Apr 14, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 15, 2020

comment:1

Easiest way to fix it is probably to use automake. Our targets in build/make/Makefile would just become "local" targets (https://www.gnu.org/software/automake/manual/html_node/Extending.html#Extending)

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Jul 5, 2020

comment:6

using automake will also make installing of gettext-related stuff in bootstrap easy

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 29, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2020

Changed keywords from none to sd111

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 19, 2020

comment:9

CFLAGS and similar were taken care of in #30375.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:10

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 1, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants