-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide precious variables (CFLAGS, PKG_CONFIG_PATH, ...) to make #29507
Comments
comment:1
Easiest way to fix it is probably to use automake. Our targets in build/make/Makefile would just become "local" targets (https://www.gnu.org/software/automake/manual/html_node/Extending.html#Extending) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:6
using automake will also make installing of gettext-related stuff in bootstrap easy |
Changed keywords from none to sd111 |
comment:9
|
comment:10
Setting new milestone based on a cursory review of ticket status, priority, and last modification date. |
autotools have a concept of "precious variables"
(https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Setting-Output-Variables.html).
Because we do not use automake, many standard precious variables such as
CFLAGS
,PKG_CONFIG_PATH
are not actually applied to building.This should be fixed to make our build system more standard.
(from discussions in #29504, and a discussion with gh-mwageringel on a ticket I lost track of)
Likewise, for variables set by
.homebrew-build-env
(https://groups.google.com/d/msg/sage-devel/taOGXzXq6Lk/ePcXsCvhBAAJ)See also:
CC: @jhpalmieri @mwageringel @dimpase @kiwifb @kliem @dcoudert
Component: build: configure
Keywords: sd111
Issue created by migration from https://trac.sagemath.org/ticket/29507
The text was updated successfully, but these errors were encountered: