Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spkg-configure.m4 for pynac #29542

Closed
thierry-FreeBSD opened this issue Apr 21, 2020 · 16 comments
Closed

spkg-configure.m4 for pynac #29542

thierry-FreeBSD opened this issue Apr 21, 2020 · 16 comments

Comments

@thierry-FreeBSD
Copy link

This ticket adds an spkg-configure.m4 for pynac, in order to use it from a system package if possible (see #27330).

Remark: it works as-is when pynac has been built without giac, i.e. if --without-giac has been set (when giac is installed, pynac finds and uses it by default). And if pynac has been built against giac, src/module_list.py must be patched.

Depends on #32386

CC: @kiwifb @orlitzky @dimpase

Component: build: configure

Keywords: spkg-configure pynac giac

Branch/Commit: public/29542 @ 1c424ad

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29542

@thierry-FreeBSD
Copy link
Author

Attachment: spkg-configure.m4.gz

spkg-configure.m4 to be put under build/pkgs/pynac/

@thierry-FreeBSD
Copy link
Author

comment:1

Note: about pynac being built against giac, see also pynac/pynac#352

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 21, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 11, 2020

Changed author from gh-thierry-FreeBSD to Thierry Thomas

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 11, 2020

Changed keywords from spkg-configure pynac to spkg-configure pynac giac

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 12, 2020

comment:4

See also #30534 - Repackage pynac as a pip-installable package (then no spkg-configure would be needed)

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 15, 2021

comment:6

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 15, 2021
@slel
Copy link
Member

slel commented Mar 22, 2021

Commit: 1c424ad

@slel
Copy link
Member

slel commented Mar 22, 2021

Changed author from Thierry Thomas to Thierry Thomas, Samuel Lelièvre

@slel
Copy link
Member

slel commented Mar 22, 2021

comment:7

Here is a branch with Thierry's spkg-configure.m4 file and distro info.


New commits:

0c0252529542: Add spkg-configure.m4 for pynac
1c424ad29542: Add pynac distro information

@slel
Copy link
Member

slel commented Mar 22, 2021

Branch: public/29542

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 22, 2021

comment:8

This is not ready. The spkg-configure.m4 would need to check that pynac works with the configured PYTHON_FOR_VENV; and the system pynac cannot be used at all if we build our own python3.

I'd rather go in the direction of #30534

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 19, 2021

comment:9

Setting a new milestone for this ticket based on a cursory review.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 16, 2021

Dependencies: #32386

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 16, 2021

Changed author from Thierry Thomas, Samuel Lelièvre to none

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 16, 2021

comment:10

#32386 makes this obsolete

@mkoeppe mkoeppe removed this from the sage-9.5 milestone Aug 16, 2021
@dimpase
Copy link
Member

dimpase commented Sep 14, 2021

Reviewer: Dima Pasechnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants