-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coxeter3: Add spkg-configure.m4, use coxeter/ prefix for includes, move OptionalExtension options to .pyx file directives #29721
Comments
This comment has been minimized.
This comment has been minimized.
New commits:
|
Commit: |
Changed keywords from none to sd109 |
comment:5
Help with this ticket would be very welcome |
Author: Matthias Koeppe, ... |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
Changed author from Matthias Koeppe, ... to Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Changed author from Matthias Koeppe to Matthias Koeppe, ... |
Changed author from Matthias Koeppe, ... to Matthias Koeppe |
Reviewer: Travis Scrimshaw |
comment:14
coxeter3 builds on my system. So LGTM. One of these days I will actually get back to converting coxeter3 to full C++ and doing some additional cleanup... |
comment:15
Thank you! |
Changed branch from u/mkoeppe/spkg_configure_m4_for_coxeter3 to |
Package exists on Arch and Fedora according to https://repology.org/project/coxeter/versions; they install coxeter in a compatible way, i.e., headers with the prefix
coxeter/
.In this ticket we change the includes in
src/sage/libs/coxeter3/decl.pxd
to use the prefixcoxeter/
, which allows us to get rid ofinclude_dirs
insrc/module_list.py
:This simplifies the work in #29720.
CC: @tscrim @dimpase @orlitzky @antonio-rojas @isuruf
Component: build: configure
Keywords: sd109
Author: Matthias Koeppe
Branch/Commit:
1497f3f
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/29721
The text was updated successfully, but these errors were encountered: