-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage: Determine SAGE_LOCAL, SAGE_ROOT via sage-config if it exists #29852
Comments
This comment has been minimized.
This comment has been minimized.
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Last 10 new commits:
|
Commit: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:10
lgtm |
Reviewer: Dima Pasechnik |
comment:11
Thanks! |
Changed branch from u/mkoeppe/get_rid_of_sage_env_config to |
Changed branch from |
comment:16
Merged the updated #22731 - needs another round of review |
Changed keywords from none to sd111 |
comment:17
Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111 |
Changed dependencies from #22731 to none |
Changed reviewer from Dima Pasechnik to Dima Pasechnik, François Bissey |
comment:21
I was rather convinced that was already in. Oh yes, it has been reverted once. It should be fine now. |
comment:22
Thank you! |
Changed branch from u/mkoeppe/get_rid_of_sage_env_config to |
We reduce the runtime dependency of
sage
onsage-env-config
.We query
sage-config
(installed bysage_conf
, which has a dependency on ourpython3
package) for the values ofSAGE_LOCAL
andSAGE_ROOT
.sage-config
must be in the same directory as $0.This allows the installed
sage
script to be invoked directly from$SAGE_LOCAL/bin
in an environment withoutSAGE_...
variables, restoring what was previously implemented in #25486.Also, we move sourcing of
sage-env-config
(but notsage-env
!) earlier in thesage
script.This is so that commands such as
$SAGE_LOCAL/bin/sage --root
work correctly.Follow-up tickets:
$SAGE_LOCAL/bin/sage
SAGE_VENV
toosrc/bin/sage-env-config
CC: @kiwifb @orlitzky @jhpalmieri @antonio-rojas @seblabbe
Component: build
Keywords: sd111
Author: Matthias Koeppe
Branch/Commit:
eb3793e
Reviewer: Dima Pasechnik, François Bissey
Issue created by migration from https://trac.sagemath.org/ticket/29852
The text was updated successfully, but these errors were encountered: