Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run test suite for gale transform #29918

Closed
kliem opened this issue Jun 20, 2020 · 10 comments
Closed

Run test suite for gale transform #29918

kliem opened this issue Jun 20, 2020 · 10 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@kliem
Copy link
Contributor

kliem commented Jun 20, 2020

We add a method that checks gale transforms and it's inverse.

We also fix two # long time flags for the snub cube:

  • one is missing spaces,
  • the other test certainly doesn't take 30 seconds anymore (I need about 2).

Depends on #29898
Depends on #29903

Component: geometry

Keywords: gale transform, test suite

Author: Jonathan Kliem

Branch/Commit: 61a7ba3

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29918
@kliem kliem added this to the sage-9.2 milestone Jun 20, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 20, 2020

Changed dependencies from #29903 to #29898, #29903

@kliem
Copy link
Contributor Author

kliem commented Jun 20, 2020

Last 10 new commits:

5c7e562fix double description of hypercube
206dbb7merged in public/29904
c6ea1ecadded long time flags
5d79b2bsome more testsuites
790dfbcfix trivial vertex facet graphs
d7cca49correct fix for 0-dimensional polyhedron
d62124fMerge branch 'public/29898' of git://trac.sagemath.org/sage into public/29918
c17428atest suite for gale transform
b7eecfbfix flags for snub cube
b2556d7missing space

@kliem
Copy link
Contributor Author

kliem commented Jun 20, 2020

Commit: b2556d7

@kliem
Copy link
Contributor Author

kliem commented Jun 20, 2020

Branch: public/29918

@kliem

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Changed commit from b2556d7 to 61a7ba3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

61a7ba3fix failing doctest

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 12, 2020

Reviewer: Matthias Koeppe

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

comment:7

Thank you.

@vbraun
Copy link
Member

vbraun commented Jul 19, 2020

Changed branch from public/29918 to 61a7ba3

@vbraun vbraun closed this as completed in 3a0ebe2 Jul 19, 2020
@kliem kliem mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @kliem