Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tox-docker builds broken by #29884 #30064

Closed
mkoeppe opened this issue Jul 4, 2020 · 10 comments
Closed

Fix tox-docker builds broken by #29884 #30064

mkoeppe opened this issue Jul 4, 2020 · 10 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 4, 2020

In 9.2.beta3 (https://github.com/sagemath/sage/runs/837071227):

Step 13/18 : RUN ./bootstrap
 ---> Running in 371ddf6853f5
rm -rf config configure build/make/Makefile-auto.in
rm -f src/doc/en/installation/*.txt
rm -rf src/doc/en/reference/spkg/*.rst
rm -f src/doc/en/reference/repl/*.txt
src/doc/bootstrap:48: installing src/doc/en/installation/arch.txt and src/doc/en/installation/arch-optional.txt
src/doc/bootstrap:48: installing src/doc/en/installation/debian.txt and src/doc/en/installation/debian-optional.txt
src/doc/bootstrap:48: installing src/doc/en/installation/fedora.txt and src/doc/en/installation/fedora-optional.txt
src/doc/bootstrap:48: installing src/doc/en/installation/cygwin.txt and src/doc/en/installation/cygwin-optional.txt
src/doc/bootstrap:48: installing src/doc/en/installation/homebrew.txt and src/doc/en/installation/homebrew-optional.txt
src/doc/bootstrap:55: installing src/doc/en/reference/spkg/*.rst
src/doc/bootstrap:83: installing src/doc/en/reference/repl/options.txt
src/doc/bootstrap: line 84: src/doc/en/reference/repl/options.txt: No such file or directory
The command '/bin/sh -c ./bootstrap' returned a non-zero code: 1

Depends on #29987

CC: @dimpase @kliem @jhpalmieri @sheerluck

Component: porting

Author: Matthias Koeppe

Branch/Commit: b7bf43b

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/30064

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jul 4, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2020

Dependencies: #29987

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2020

Commit: b7bf43b

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2020

New commits:

539c182build/make/install: Do not depend on src/bin/sage-version.sh
761092cMerge branch 't/29987/build_make_install__do_not_depend_on_src_bin_sage_version_sh' into t/30064/fix_tox_docker_builds_broken_by__29884
f2efa6asrc/doc/bootstrap: Create the directory src/doc/en/reference/repl if it does not exist
b7bf43bbuild/bin/write-dockerfile.sh: ADD src/bin for bootstrapping, needed by src/doc/bootstrap after #29884

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 4, 2020

comment:3

Tests run at https://github.com/mkoeppe/sage/actions/runs/157676066

@kliem
Copy link
Contributor

kliem commented Jul 5, 2020

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Jul 5, 2020

comment:4

LGTM.

Strangly, centos 7 works again. So maybe we can mark #30008 as invalid then.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 5, 2020

comment:5

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 10, 2020

Changed branch from u/mkoeppe/fix_tox_docker_builds_broken_by__29884 to b7bf43b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants