Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal fix for broken jupyter notebook #30299

Closed
mkoeppe opened this issue Aug 6, 2020 · 14 comments
Closed

Minimal fix for broken jupyter notebook #30299

mkoeppe opened this issue Aug 6, 2020 · 14 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 6, 2020

CC: @dimpase @nbruin @slel @paulmasson @kiwifb @EmmanuelCharpentier @jhpalmieri @jcamp0x2a

Component: user interface

Keywords: jupyter threejs jsmol mathjax

Author: Matthias Koeppe

Branch: 79317b8

Reviewer: Paul Masson

Issue created by migration from https://trac.sagemath.org/ticket/30299

@mkoeppe mkoeppe added this to the sage-9.2 milestone Aug 6, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 6, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 6, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 6, 2020

Commit: 79317b8

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 6, 2020

New commits:

79317b8build/pkgs/sage_conf/src/sage_conf.py.in: Add JSMOL_DIR, MATHJAX_DIR, THREEJS_DIR

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Aug 6, 2020

Changed keywords from none to jupyter threejs jsmol mathjax

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Aug 6, 2020

Reviewer: Paul Masson

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Aug 6, 2020

comment:3

I can confirm this fix allows the notebook to run and both Three.js and JSMol function as expected. If it is ready for review, then it can be set to positive so it gets into the next beta.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 6, 2020

comment:4

Thanks for testing!

@slel
Copy link
Member

slel commented Aug 7, 2020

comment:6

Thanks. Somewhat related, can anyone help with the plot3d issue at:

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Aug 7, 2020

comment:8

Joshua, can you replicate the plot3d error in the Ask Sage question? Happening on a version of Ubuntu.

@jcamp0x2a
Copy link
Mannequin

jcamp0x2a mannequin commented Aug 7, 2020

comment:9

Heya! 20.04 bricked my Ubuntu machine, and I've been too stubborn to rollback as of yet. I tried the example in the AskSage question with my WSL installation of Ubuntu 18.04 and was unable to reproduce the reported problem. The plot showed up just fine. I'll try again once I either get my upgrade woes sorted out or (very) begrudgingly rollback.

@vbraun
Copy link
Member

vbraun commented Aug 9, 2020

Changed branch from u/mkoeppe/minimal_fix_for_broken_jupyter_notebook to 79317b8

@egourgoulhon
Copy link
Member

Changed commit from 79317b8 to none

@egourgoulhon
Copy link
Member

comment:11

Replying to @jcamp0x2a:

Heya! 20.04 bricked my Ubuntu machine, and I've been too stubborn to rollback as of yet. I tried the example in the AskSage question with my WSL installation of Ubuntu 18.04 and was unable to reproduce the reported problem. The plot showed up just fine. I'll try again once I either get my upgrade woes sorted out or (very) begrudgingly rollback.

I confirm that the example in the AskSage question works fine with Sage 9.1 on my Ubuntu 18.04 machine (same version of Ubuntu than the OP).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants