Immutability of Scalar Fields II

[mjungmath]

Immutability of scalar fields, see #30261.

Pass immutability to chart functions bound to scalar fields.

Depends on #30266
Depends on #30310
Depends on #30181

CC: @egourgoulhon @tscrim @mkoeppe

Component: manifolds

Keywords: immutability

Author: Michael Jung

Branch/Commit: 6f39d6e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30311

[mjungmath]

Branch: u/gh-mjungmath/immutability_of_scalar_fields_ii

[mjungmath]

Commit: 958ad16

[mjungmath]

Author: Michael Jung

[mjungmath]

Changed keywords from none to immutability

[mjungmath]

Last 10 new commits:

055d226	Trac #30266: Merge branch 't/30116/test_comparison_tensorfield' into t/30266/immutability_for_scalar_fields
8ca8b75	Trac #30266: hash compatibility check wrt #30116
0bf9f36	Trac #30266: Merge branch 'develop' into t/30266/immutability_for_scalar_fields
a5f6a19	Trac 30266: hash function slightly improved
37b0042	Trac #30266: remove dependency of #30116
2f72e19	Trac #30266: if statement missing
8600c2d	Merge branch 't/30181/immutable_elements_of_freemoduletensor' into t/30310/immutability_of_chart_functions
76229bd	Trac #30310: immutability of chart functions
48a35b1	Merge branch 't/30310/immutability_of_chart_functions' into t/30311/immutability_of_scalar_fields_ii
958ad16	Trac 30311: apply set_immutable to chart functions

[mjungmath]

Dependencies: #30266, #30310

[mjungmath]

Changed dependencies from #30266, #30310 to #30266, #30310, #30181

[sagetrac-git]

Changed commit from 958ad16 to 6f39d6e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

7247620	Merge branch 'develop' into t/30310/immutability_of_chart_functions
5ecbf3a	Trac #31181: return added
8b20fc4	Merge branch 't/31181/mutability_class_does_not_return_is_immutable' into t/30310/immutability_of_chart_functions
4c33935	Trac #31196: minor code improvements, py3 compatibility, documentation improved
e5228d3	Trac #31196: cpdef require methods + example added
d957f73	Trac #31196: unnecessary line in docstring removed
d6d6ba4	Trac #31182: `__getstate__` and __setstate__
6cbd1fd	Trac #31182: doctests added for `__setstate__` and __getstate__
848e96b	Merge branch 't/31182/mutability_class_and_pickling' into t/30310/immutability_of_chart_functions
6f39d6e	Trac #30311: apply set_immutable to all chart functions

[mjungmath]

comment:11

Should be a green patchbot (startup time fails).

By the way: Why does the startup time fail so often? What's going on there?

[tscrim]

comment:12

That is a bit fickle of a test. I wouldn't pay too much attention to it, but it is good to check it quickly to see if there is something causing a major slowdown on startup.

[mkoeppe]

comment:13

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

[mjungmath]

comment:14

Can we consider this ticket as done? Travis, Eric?

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:15

Yep, LGTM.

[vbraun]

Changed branch from u/gh-mjungmath/immutability_of_scalar_fields_ii to 6f39d6e