Add pycodestyle config via tox, add tox environment

[tobiasdiez]

Adds the current configuration of pycodestyle (as taken from the patchbot) to the src/tox.ini file. Thus, it can be run now locally via the cli pycodestyle. Moreover, tools like VS Code can pick it up automatically. The corresponding changes for the patchbot are done in sagemath/sage-patchbot#145.

Documentation will be added in #30361.

CC: @mkoeppe @fchapoton

Component: build

Author: Tobias Diez, Matthias Koeppe

Branch: 939e9e0

Reviewer: Matthias Koeppe, Tobias Diez

Issue created by migration from https://trac.sagemath.org/ticket/30408

[mkoeppe]

comment:2

Perhaps also add a tox environment that runs pycodestyle?

[mkoeppe]

comment:3

Speaking of vs code, would it make sense to add a configuration or configuration template for that as well in ~/.vscode so that it knows to launch local/bin/sage and local/bin/python3?

[tobiasdiez]

comment:4

Perhaps also add a tox environment that runs pycodestyle?

I've no experience with tox, and thus cannot decide if this makes sense or not. Feel free to hijack this PR and add the necessary config.

Speaking of vs code, would it make sense to add a configuration or configuration template for that as well in ~/.vscode so that it knows to launch local/bin/sage and local/bin/python3?

This definitely makes sense! However, the last time I tried to point vscode to the local sage python environment, it didn't work. My hope was that with the inplace compilation it will work.

[mkoeppe]

comment:5

Replying to @tobiasdiez:

Speaking of vs code, would it make sense to add a configuration or configuration template for that as well in ~/.vscode so that it knows to launch local/bin/sage and local/bin/python3?

This definitely makes sense! However, the last time I tried to point vscode to the local sage python environment, it didn't work. My hope was that with the inplace compilation it will work.

I was able to set it so that it can run local/bin/python3 and that was good enough to do some debugging work

[mkoeppe]

comment:6

Replying to @tobiasdiez:

Perhaps also add a tox environment that runs pycodestyle?

I've no experience with tox, and thus cannot decide if this makes sense or not. Feel free to hijack this PR and add the necessary config.

Sure, will do

[sagetrac-git]

Changed commit from 1cedc00 to dde3b4f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

dde3b4f

src/tox.ini: Add testenv:pycodestyle

[mkoeppe]

Author: Tobias Diez, Matthias Koeppe

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

939e9e0

src/tox.ini: Better default arg testenv:pycodestyle

[sagetrac-git]

Changed commit from dde3b4f to 939e9e0

[mkoeppe]

comment:10

This auto-provisions pycodestyle

Can do the same also for pyright via https://pypi.org/project/nodeenv/

[tobiasdiez]

comment:11

Thanks!

If you want to enable type checking in a purely pythonic environment, then perhaps mypy (or pytype or PyCharm) are better alternatives. Pyright was mainly designed to be used in combination with VS code and for CI. Anyway, that's not the topic of this ticket ;-).

[mkoeppe]

comment:13

Replying to @tobiasdiez:

Pyright was mainly designed to be used in combination with VS code and for CI. Anyway, that's not the topic of this ticket ;-).

OK, I've opened #30411 for this, but it's not a high priority to work on it.

[mkoeppe]

Reviewer: Matthias Koeppe, Tobias Diez

[vbraun]

Changed branch from public/build/pycodestyleConfig to 939e9e0

[mkoeppe]

comment:17

Replying to @mkoeppe:

Speaking of vs code, would it make sense to add a configuration or configuration template for that as well in ~/.vscode so that it knows to launch local/bin/sage and local/bin/python3?

This is now #30484

[mkoeppe]

Changed commit from 939e9e0 to none