Make tox a standard package #30416

Should there also be an spkg-configure.m4 file? (As a policy issue, should all new standard packages be encouraged, required if at all possible, to have such files, to try to maintain the momentum toward working well with distros?)

mkoeppe · 2020-09-09T18:21:01Z

comment:6

That's a good idea, and I would support adding this policy too.

sagetrac-git · 2020-09-09T21:02:21Z

Branch pushed to git repo; I updated commit sha1. New commits:

`3b510dd`	`build/pkgs/tox/spkg-configure.m4: New`

sagetrac-git · 2020-09-09T21:02:21Z

Changed commit from 6913cd8 to 3b510dd

jhpalmieri · 2020-09-09T21:34:06Z

comment:9

Replying to @mkoeppe:

That's a good idea, and I would support adding this policy too.

See #30543 for documentation for spkg-configure.m4 and the statement of this policy.

jhpalmieri · 2020-09-09T22:41:34Z

comment:10

We're missing some dependencies:

install_requires = 
	filelock>=3.0.0
	packaging>=14
	pluggy>=0.12.0
	py>=1.4.17
	six>=1.14.0 # required when virtualenv>=20
	toml>=0.9.4
        virtualenv!=20.0.0,!=20.0.1,!=20.0.2,!=20.0.3,!=20.0.4,!=20.0.5,!=20.0.6,!=20.0.7,>=16.0.0
	colorama>=0.4.1 ;platform_system=="Windows"
	importlib-metadata>=0.12,<2;python_version<"3.8"

When I run ./sage --tox --version, I get

ModuleNotFoundError: No module named 'pluggy'

mkoeppe · 2020-09-10T00:00:35Z

comment:11

Indeed, thanks for catching this.

mkoeppe · 2020-09-10T00:39:53Z

Dependencies: #30544

sagetrac-git · 2020-09-10T00:41:04Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

sagetrac-git · 2020-09-10T00:41:04Z

Changed commit from 3b510dd to f8a7ee6

sagetrac-git · 2021-01-02T04:39:11Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`6f3b864`	`build/pkgs/[s-t]*/SPKG.rst: Reformat title in format 'spkg_name: Short description'`
`23558f8`	`build/pkgs/[t-z]*/SPKG.rst: Reformat title in format 'spkg_name: Short description' -- completes coverage of all standard packages`
`17789df`	`build/pkgs/[z-z]*/SPKG.rst: Reformat title in format 'spkg_name: Short description' -- completes coverage of all optional packages`
`944408d`	`build/pkgs/[a-z]*/SPKG.rst: Reformat title in format 'spkg_name: Short description' -- completes coverage of all experimental packages`
`feafa60`	`src/doc/en/installation/standard_packages.rst: Remove`
`58c63e1`	`src/doc/bootstrap: Add brief explanation of the standard/optional/experimental package types`
`54d4fb1`	`extra line after version`
`565dd46`	`Merge branch 't/29655/improve_build_pkgs___spkg_rst' into t/30416/make_tox_a_standard_package`
`7f4c0b2`	`build/pkgs/{distlib,appdirs,importlib_resources}: Add dependencies of virtualenv`
`b51cf6b`	`build/pkgs/virtualenv/dependencies: Add deps`

mkoeppe · 2021-01-02T04:39:44Z

Changed dependencies from #30544 to #29655

mkoeppe · 2021-05-27T22:48:16Z

Changed dependencies from #29655 to #31699

sagetrac-git · 2021-05-27T22:52:05Z

Changed commit from b51cf6b to cc2f4ae

sagetrac-git · 2021-05-27T22:52:05Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

`012774f`	`build/pkgs/packaging: Update to 20.9`
`fff89bc`	`build/pkgs/importlib_metadata: Update to 4.0.1`
`e14a5ed`	`build/pkgs/pip: Update to 21.1.1`
`3386fa1`	`build/pkgs/toml: New`
`71aeec7`	`build/pkgs/typing_extensions: New`
`ecdf3e1`	`build/pkgs/importlib_metadata/dependencies: Update`
`2e74014`	`Merge #31699`
`e694b15`	`build/pkgs/tox: Make it a standard package`
`9c7a1c2`	`build/pkgs: Add tox dependencies: filelock py virtualenv pluggy`
`cc2f4ae`	`build/pkgs/{distlib,appdirs,importlib_resources}: Add dependencies of virtualenv`

sagetrac-git · 2021-05-27T23:11:43Z

Changed commit from cc2f4ae to b9c4ec8

sagetrac-git · 2021-05-27T23:11:43Z

Branch pushed to git repo; I updated commit sha1. New commits:

`5488ecd`	`build/pkgs: Update tox and dependencies to latest`
`b9c4ec8`	`build/pkgs/packaging/checksums.ini: Add upstream_url`

jhpalmieri · 2021-05-28T05:27:16Z

comment:26

py doesn't build for me; even if it did, it looks like it's trying to download things at the start of its build process. Log attached.

sagetrac-git · 2021-05-28T05:35:23Z

comment:27

Attachment: py-1.10.0.log

Branch pushed to git repo; I updated commit sha1. New commits:

`ef12a3e`	`build/pkgs/pkgconfig/checksums.ini: Add upstream_url`
`7a6d0b6`	`build/pkgs/packaging/checksums.ini: Add upstream_url`
`6abfe84`	`Merge #31699`
`ce2ec11`	`build/pkgs/py/dependencies: Add setuptools_scm (a setup-requires)`

sagetrac-git · 2021-05-28T05:35:23Z

Changed commit from b9c4ec8 to ce2ec11

jhpalmieri · 2021-05-28T16:50:33Z

comment:28

It's a little unfortunate that the top-level configure recognizes that

configure:38013: checking for tox >= 2.5.0
configure:38096: result: /usr/local/bin/tox
configure:38107: will use system package and not install SPKG tox

but our build system isn't smart enough to skip its dependencies.

mkoeppe · 2021-05-28T16:55:36Z

comment:29

Great point! I'll see what I can do about this

sagetrac-git · 2021-05-29T00:54:28Z

Changed commit from ce2ec11 to 65e6330

sagetrac-git · 2021-05-29T00:54:28Z

Branch pushed to git repo; I updated commit sha1. New commits:

`65e6330`	`build/pkgs{appdirs,distlib,filelock,virtualenv}/spkg-configure.m4: Mark as not required if system tox is used`

mkoeppe · 2021-05-29T01:06:52Z

comment:31

Here's something that will avoid installing 4 packages in this case:

appdirs, distlib, filelock, virtualenv

I haven't added the same logic to the other packages:

pluggy, py, toml -- because they will also be needed as dependencies of pytest (see Make pytest a standard package #31110)
importlib_resources -- because it is useful as a backport package (see sage.repl: Replace use of SAGE_EXTCODE by importlib.resources #31306)

jhpalmieri · 2021-05-31T03:53:25Z

comment:32

Okay, thanks, looks good.

jhpalmieri · 2021-05-31T03:53:25Z

Reviewer: John Palmieri

mkoeppe · 2021-05-31T05:32:42Z

comment:33

Thanks!

vbraun · 2021-06-20T08:14:31Z

Changed branch from u/mkoeppe/make_tox_a_standard_package to 65e6330

kliem · 2021-06-22T09:00:47Z

comment:35

Replying to @jhpalmieri:

py doesn't build for me; even if it did, it looks like it's trying to download things at the start of its build process. Log attached.

What was the resolution to this?

I'm getting build failure of sage because of this now. It's not terrible and I guess py isn't needed by anything. But I'm also wondering, why it is a dependency of tox and pytest in the first place. Neither of them lists py as a dependency. Where do we use it?

kliem · 2021-06-22T09:00:47Z

Changed commit from 65e6330 to none

mkoeppe · 2021-06-22T13:41:09Z

comment:36

Replying to @kliem:

Replying to @jhpalmieri:

py doesn't build for me; even if it did, it looks like it's trying to download things at the start of its build process. Log attached.

What was the resolution to this?

The missing dependency on setuptools_scm was added

I'm getting build failure of sage because of this now. It's not terrible and I guess py isn't needed by anything. But I'm also wondering, why it is a dependency of tox and pytest in the first place. Neither of them lists py as a dependency. Where do we use it?

It's an install_requires of tox: https://github.com/tox-dev/tox/blob/master/setup.cfg

mkoeppe added this to the sage-9.2 milestone Aug 21, 2020

mkoeppe added c: packages: standard labels Aug 21, 2020

This comment has been minimized.

Sign in to view

mkoeppe added the s: needs review label Sep 9, 2020

mkoeppe added s: needs work and removed s: needs review labels Sep 9, 2020

mkoeppe added s: needs review and removed s: needs work labels Sep 9, 2020

mkoeppe added s: needs work and removed s: needs review labels Sep 10, 2020

This comment has been minimized.

Sign in to view

mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 10, 2020

mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 20, 2021

mkoeppe added s: needs review and removed s: needs work labels May 27, 2021

jhpalmieri added s: positive review and removed s: needs review labels May 31, 2021

vbraun removed the s: positive review label Jun 20, 2021

vbraun closed this as completed in f8e8755 Jun 20, 2021

Make tox a standard package #30416

Make tox a standard package #30416

Comments

mkoeppe commented Aug 21, 2020

This comment has been minimized.

mkoeppe commented Sep 9, 2020

mkoeppe commented Sep 9, 2020

mkoeppe commented Sep 9, 2020

mkoeppe commented Sep 9, 2020

jhpalmieri commented Sep 9, 2020

mkoeppe commented Sep 9, 2020

sagetrac-git mannequin commented Sep 9, 2020

sagetrac-git mannequin commented Sep 9, 2020

jhpalmieri commented Sep 9, 2020

jhpalmieri commented Sep 9, 2020

mkoeppe commented Sep 10, 2020

This comment has been minimized.

This comment has been minimized.

mkoeppe commented Sep 10, 2020

sagetrac-git mannequin commented Sep 10, 2020

sagetrac-git mannequin commented Sep 10, 2020

sagetrac-git mannequin commented Jan 2, 2021

mkoeppe commented Jan 2, 2021

mkoeppe commented May 27, 2021

sagetrac-git mannequin commented May 27, 2021

sagetrac-git mannequin commented May 27, 2021

sagetrac-git mannequin commented May 27, 2021

sagetrac-git mannequin commented May 27, 2021

jhpalmieri commented May 28, 2021

sagetrac-git mannequin commented May 28, 2021

sagetrac-git mannequin commented May 28, 2021

jhpalmieri commented May 28, 2021

mkoeppe commented May 28, 2021

sagetrac-git mannequin commented May 29, 2021

sagetrac-git mannequin commented May 29, 2021

mkoeppe commented May 29, 2021

jhpalmieri commented May 31, 2021

jhpalmieri commented May 31, 2021

mkoeppe commented May 31, 2021

vbraun commented Jun 20, 2021

kliem commented Jun 22, 2021

kliem commented Jun 22, 2021

mkoeppe commented Jun 22, 2021