-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spheres smoothly embedded in Euclidean Space to Manifold Catalog #30804
Comments
This comment has been minimized.
This comment has been minimized.
comment:2
Establishing the stereographic projection in more than 3 dimensions is very demanding, even if you know the inverse. I know that you can speed these things up a little by turning off checking and choosing a suitable simplification. But do you know more workarounds? I also suspect that the Jacobian takes a long time. |
comment:3
Even if it takes a long time, IMO it still is good to have a general version (with a warning to the user about the time). |
comment:4
I agree. It is good to have these examples. I thought about computing the desired quantities only on demand. Unfortunately it turned out difficult since most quantities are integral components and invoked by attributes not by methods. That's why I usually prefer methods rather than attributes. |
This comment has been minimized.
This comment has been minimized.
comment:6
Please take a peek at this first approach. I'd appreciate if someone can take a closer look at the details, i.e. transition maps, choice of subsets etc. I tried to cover spherical coordinates in arbitrary dimensions as well. But it turned out that the transition map to the stereographic coordinates is a bit complicated in the general setup. I welcome any kind of reference that might help. Furthermore, I wanted to ensure that the spherical coordinates have the correct orientation right from the start. That explains the reordering of coordinates compared to Wikipedia, and it makes the transition map to figure out even more tricky. New commits:
|
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
This should be the correct transition map, now. Checks all pass, too. I hope I didn't mess up the domains. Please check. Examples follow. |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:12
Replying to @mjungmath:
A very good reference for the sphere in any dimension is Chapter 18 The sphere for its own sake in Marcel Berger: Geometry, vol. II, Universitext. Springer-Verlag, Berlin, 1987.
On general grounds, I don't think we should depart from Wikipedia conventions without a good reason. Moreover, I think it is standard convention to have the periodic coordinate on Sn to be the last one (as in (theta, phi) for S2), not the first one. |
comment:13
Replying to @egourgoulhon:
Thanks. I'll take a look.
We have to deviate from the Wikipedia convention anyway. This is simply because the slit we take out for spherical coordinates should meet the poles. Currently, the north/south pole is encoded in the last coordinate. We can shift it to the first, and then we can recover the conventions in Wikipedia for spherical coordinates. But that would be another convention we break, namely for the stereographic projection. |
comment:14
Replying to @mjungmath:
Sorry I don't understand what you mean. It seems to me that we can keep Wikipedia conventions, both for spherical coordinates and stereographic ones, as we do already for S2 in this example. Then the spherical frame and the stereographic frame from the South pole are right-handed and the stereographic frame from the North pole is left-handed. |
comment:15
Replying to @egourgoulhon:
That's right. But notice that the convention in the general case is slightly different than in the 2-sphere case, compare [https://en.wikipedia.org/wiki/N-sphere#Spherical_coordinates [1]] with [https://en.wikipedia.org/wiki/Spherical_coordinate_system#Cartesian_coordinates [2]]. If you consider the embedding in spherical coordinates in the general case, and follow the convention [1], it appears to happen that the poles do not belong to the removed meridian. So what I did was reversing the order of the Whatever convention we choose, I will provide a thorough documentation of the conventions used in the implementation anyway. |
comment:16
Attachment: spherical.png I have added the choice of coordinates and their inverse in an attachment. I think the formulas look very nice this way (provided I haven't miscalculated). |
comment:19
I see these options:
I personally vote for 1 as long as the documentation is thorough enough. |
comment:21
I gave it a little thought. I think option 4 is best. Option 4 is in a way canonical: we obtain the convention for In addition, we don't need an extra class with facade pattern for 1D and 2D. Agreed? |
comment:22
This sounds like a good plan. I'm not sure if that works, but is it possible to add all these different conventions as additional charts? Then the user can decide which convention he wants to follow. This would also be the most flexible approach (e.g. to verify formulas in different conventions etc). |
comment:23
Replying to @tobiasdiez:
I agree that this would be the best option. But I suspect that it is not worth the effort. Furthermore, these details can be added by time. I think, a non-primitive working sphere example in any dimension is enough for now. |
comment:39
By the way, I noticed that there is no section in the documentation dedicated to general examples (except for |
comment:40
You can just set it to needs review now; if there are more comments then people can provide it then. |
comment:42
Squashed commits. Ready for review. |
Author: Michael Jung |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:47
Patchbot full green. |
Reviewer: Eric Gourgoulhon, Travis Scrimshaw |
comment:48
Good for me. Travis, do you agree? |
comment:49
Yep, I agree. |
comment:50
Thank you! :) Eric, would you mind going for the Hopf coordinates? |
comment:51
Replying to @mjungmath:
Thank you for this work.
I'll be happy to make a ticket for S3 as a subclass of |
Changed branch from u/gh-mjungmath/add_standard_sphere_to_manifold_catalog to |
Changed commit from |
comment:53
See #31781 for a follow-up. |
See #30189.
The current catalog only provides spheres of dimension two. A comprehensive and faster version will be added here.
Features:
homology
moduleFollow-Ups:
S^1
,S^3
andS^7
parallelizableS^3
S^1
andS^3
CC: @egourgoulhon @tscrim @tobiasdiez
Component: manifolds
Author: Michael Jung
Branch:
caa9d5f
Reviewer: Eric Gourgoulhon, Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/30804
The text was updated successfully, but these errors were encountered: