Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mathjax configuration/symlink from jupyter notebook #31035

Closed
mkoeppe opened this issue Dec 10, 2020 · 19 comments
Closed

Remove mathjax configuration/symlink from jupyter notebook #31035

mkoeppe opened this issue Dec 10, 2020 · 19 comments
Labels
c: user interface p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 10, 2020

(from #30296)

Jupyter ships with its own copy of mathjax already.

We remove the installation of the symlink to our copy of mathjax from the nbextensions directory and the corresponding configuration item from the notebook.

See also a related documentation issue in #24367.

CC: @slel @egourgoulhon @jhpalmieri @enriqueartal @kiwifb @antonio-rojas @jcamp0x2a @defeo @EmmanuelCharpentier

Component: user interface

Keywords: sd111

Author: Matthias Koeppe

Branch/Commit: 2d68ed7

Reviewer: Antonio Rojas

Issue created by migration from https://trac.sagemath.org/ticket/31035
@mkoeppe mkoeppe added this to the sage-9.3 milestone Dec 10, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2020

Branch: u/mkoeppe/remove_mathjax_configuration_symlink_from_jupyter_notebook

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2020

New commits:

2c2b103Remove mathjax configuration/symlink from jupyter notebook

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2020

Commit: 2c2b103

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2020

Changed keywords from none to sd111

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 10, 2020

comment:5

To be considered in the review of this ticket:

  • Is there any difference in font rendering between the mathjax that comes with Jupyter notebook and our copy of mathjax? Does Jupyter notebook rely on online resources for any font rendering?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

9990130Merge branch 'develop' of git://trac.sagemath.org/sage into t/31035/remove_mathjax_configuration_symlink_from_jupyter_notebook

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2020

Changed commit from 2c2b103 to 9990130

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 17, 2021

comment:9

faulty merge needs fixing

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2021

Changed commit from 9990130 to 255348f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

255348fRemove mathjax configuration/symlink from jupyter notebook

@antonio-rojas
Copy link
Contributor

comment:12

Still some leftovers from bad merge

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2d68ed7Remove mathjax configuration/symlink from jupyter notebook

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2021

Changed commit from 255348f to 2d68ed7

@antonio-rojas
Copy link
Contributor

Reviewer: Antonio Rojas

@antonio-rojas
Copy link
Contributor

comment:15

WFM with system jupyter

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 20, 2021

comment:16

Thanks!

@vbraun
Copy link
Member

vbraun commented Jan 31, 2021

Changed branch from u/mkoeppe/remove_mathjax_configuration_symlink_from_jupyter_notebook to 2d68ed7

@vbraun vbraun closed this as completed in 6dda91c Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: user interface p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @antonio-rojas