Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated form input for bundle connections #31273

Closed
mjungmath opened this issue Jan 21, 2021 · 8 comments
Closed

Remove deprecated form input for bundle connections #31273

mjungmath opened this issue Jan 21, 2021 · 8 comments
Labels
c: manifolds p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@mjungmath
Copy link

We remove the form input for add_connection_form and set_connection_form because it is deprecated since #30208.

CC: @tscrim @egourgoulhon

Component: manifolds

Keywords: bundle connection

Author: Michael Jung

Branch/Commit: 5381682

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/31273
@mjungmath mjungmath added this to the sage-9.3 milestone Jan 21, 2021
@mjungmath
Copy link
Author

Branch: u/gh-mjungmath/remove_deprecated__form__input_for_bundle_connections

@mjungmath
Copy link
Author

Commit: 5381682

@mjungmath
Copy link
Author

New commits:

5381682Trac #31273: remove deprecated "form" input

@mjungmath
Copy link
Author

comment:3

Patchbot green.

@egourgoulhon
Copy link
Member

comment:4

LGTM.

@egourgoulhon
Copy link
Member

Reviewer: Eric Gourgoulhon

@egourgoulhon
Copy link
Member

Changed keywords from none to bundle connection

@vbraun
Copy link
Member

vbraun commented Jan 31, 2021

Changed branch from u/gh-mjungmath/remove_deprecated__form__input_for_bundle_connections to 5381682

@vbraun vbraun closed this as completed in bfe6fd9 Jan 31, 2021
@mjungmath mjungmath mentioned this issue Mar 22, 2021
Closed
@egourgoulhon egourgoulhon mentioned this issue Jan 30, 2023
Open
@mjungmath mjungmath mentioned this issue Jan 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: manifolds p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @egourgoulhon @mjungmath