widgetsnbextension should not depend on notebook

[mkoeppe]

This dependency pulls in a full installation of the Jupyter notebook.

notebook>=4.4.1->widgetsnbextension~=3.5.0->ipywidgets==7.5.1

This is an obstacle to avoiding to build a copy of the jupyter notebook (connecting to a system jupyter notebook).

The dependency is being removed in the widgetsnbextension 4.x series (currently alpha). We backport it to the stable release.

Depends on #31328

Upstream: Fixed upstream, but not in a stable release.

CC: @kiwifb @isuruf @antonio-rojas @jcamp0x2a @tobiasdiez @kliem

Component: packages: standard

Author: Matthias Koeppe

Branch: 5141bc3

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/31278

[mkoeppe]

comment:2

In a first step we could patch out this dependency - then the wheel that we build at least won't pull the notebook into a user venv.

[mkoeppe]

Dependencies: #31328

[mkoeppe]

Upstream: Not yet reported upstream; Will do shortly.

[mkoeppe]

Changed upstream from Not yet reported upstream; Will do shortly. to Workaround found; Bug reported upstream.

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Branch: u/mkoeppe/ipywidgets-should-not-depend-on-widgetsnbextension

[mkoeppe]

Commit: 1062a3b

[mkoeppe]

comment:10

Upstream indicates in response to jupyter-widgets/ipywidgets#3080 that they instead plan to remove the dependency of widgetsnbextension on notebook in 8.0.

---

New commits:

a8035aa	build/pkgs/ipywidgets: Upgrade to 7.6.3
fab1cb0	build/pkgs/ipywidgets: Patch out dependency on widgetsnbextension, jupyterlab_widgets
1062a3b	build/pkgs/ipywidgets/dependencies: Remove widgetsnbextension

[mkoeppe]

comment:11

In fact, this change is already in jupyter-widgets/ipywidgets@7ea681e#diff-e56eea957358c7c07362fde8ec3a3a8a8fbbeaa825b998cf4ea9191c55b1a0fd

[mkoeppe]

comment:13

We can patch our widgetsnbextension with a backport of this.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5141bc3

build/pkgs/widgetsnbextension: Patch out dependency on notebook (backport from widgetsnbextension-4)

[sagetrac-git]

Changed commit from 1062a3b to 5141bc3

[mkoeppe]

Changed upstream from Workaround found; Bug reported upstream. to Fixed upstream, but not in a stable release.

[dimpase]

comment:17

this installs OK. More testing...

[dimpase]

comment:18

lgtm

[dimpase]

Reviewer: Dima Pasechnik

[mkoeppe]

comment:19

Thanks!

[vbraun]

Changed branch from u/mkoeppe/ipywidgets-should-not-depend-on-widgetsnbextension to 5141bc3

[mkoeppe]

comment:21

Follow up: #31523

[mkoeppe]

Changed commit from 5141bc3 to none