Add package argon2-cffi (dependency of Jupyter notebook)

[mkoeppe]

This is an install-requires of notebook.

In #26919 we did not add it, but if we let Python dependencies play out (for example as in #30913), it gets pulled in by sagelib via ipywidgets (see also #31278).

CC: @jcamp0x2a @slel @kcrisman @dimpase @jhpalmieri @tobiasdiez

Component: packages: standard

Author: Matthias Koeppe

Branch: 45e5cd2

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/31279

[mkoeppe]

Branch: u/mkoeppe/add_package_argon2_cffi

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

f4273b7	build/pkgs/argon2_cffi: New
3cec11b	build/pkgs/notebook/dependencies: Add argon2_cffi

[mkoeppe]

Commit: 3cec11b

[jhpalmieri]

comment:5

I don't understand this ticket. If I build Sage and run the notebook, argon-cffi is not installed anywhere, as far as I can tell. What am I missing?

[mkoeppe]

comment:6

We install all packages using pip install --no-deps (see build/bin/sage-pip-install), so dependencies that the package declares as install-requires are not automatically installed. As a result, I assume some feature of the Jupyter notebook must be unavailable; but I do not know what exactly.

[jhpalmieri]

comment:7

argon2-cffi does something with password hashing, and I don't know if it's really necessary. I don't know enough about the security of the Jupyter notebook, or how argon2-cffi would help, to make a decision.

[mkoeppe]

comment:8

used here: https://github.com/jupyter/notebook/blob/bc28d6123117c3c733697e27e9d4bd71d7f0c46b/notebook/auth/security.py

[kliem]

comment:9

We need to set ARGON2_CFFI_USE_SSE2 to 0 in case of SAGE_FAT_BINARY.

https://argon2-cffi.readthedocs.io/en/stable/installation.html

[kliem]

Reviewer: Jonathan Kliem

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

45e5cd2

build/pkgs/argon2_cffi/spkg-install.in: Handle SAGE_FAT_BINARY

[sagetrac-git]

Changed commit from 3cec11b to 45e5cd2

[kliem]

comment:13

LGTM.

[mkoeppe]

comment:14

Thank you!

[vbraun]

Changed branch from u/mkoeppe/add_package_argon2_cffi to 45e5cd2

[mkoeppe]

comment:16

Follow up in #31441

[mkoeppe]

Changed commit from 45e5cd2 to none